Django 4.1 and other requirements #1799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niklasmohrin
force-pushed
the
django-4.1
branch
from
6461443 to
81e2e05
Compare
richardebeling
approved these changes
Aug 29, 2022
Among the breaking changes, there is one that immediatly causes problems:
In order to unify the behavior with many-to-many relations for
unsaved model instances, a reverse foreign key now raises ValueError
when calling related managers for unsaved objects.
https://docs.djangoproject.com/en/4.1/releases/4.1/#reverse-foreign-key-changes-for-unsaved-model-instances
As a quickfix, I added `pk is not None` in two places, I am not sure
yet whether this is exactly what we want though.
We still get errors with logged models when upgrading `django-stubs` (see e-valuation#1767).
With Django 4.1, `collectstatic` apparently cares about sourcemaps and complains about a missing one after the update. The css file for tom-select's bootstrap css had the indicator comment for a corresponding source map, but we didn't have the file. Removing the indicator comment works too, but that would mean that we distribute a modififed version of the css file.
niklasmohrin
force-pushed
the
django-4.1
branch
from
81e2e05 to
8580540
Compare
|
There is a new version of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1796
See commit messages. The ideas about using constraints instead of asserts from the issue can be done in another PR. The cached template things don't seem to be a problem, I get new html after editing files without restarting the server.