Fix #1804 - Bad request on failed redemption

[florian-str]

Fix for issue #1804

[richardebeling]

Thanks a lot! The view code looks very good. For the tests, we think we can use the status argument on all requests that we issue, so we only have the expected error in one line instead of two lines.

[niklasmohrin]

About the linter error: In the original PR where we noticed this issue, we moved the code into a new function. As this PR is still open, I am fine with ignoring the warning for this PR as #1790 will fix it again.

To silence the warning, add a line with # pylint: disable=too-many-locals at the top of the function.

[richardebeling]

Our linter (pylint) performs a static analysis of the code without any call-chain inference. We thus have to disable the check in the scope where it fails otherwise (because there are too many locals according to our rules). If you move the # pylint: disable=too-many-locals comment into the rewards/views.py index view, as shown in the change suggestions below, it should work.

Don't worry about the typescript tests, that failure was unrelated to your changes. We will have to fix that outside of this PR.