Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the navbar cache.
Should thus fix #1645. Increases page load times by ~20ms. I tried
request.user
to allow the privilege-checks to happen without database hits.Both didn't really change much about the performance. At 40-60ms to render a static view, the effects of removing singular db hits is really hard to qualify. I left the semester logic in, as it is contained, and reverted the user profile groups stuff, as prefetching is a bit tricky to do there: We only want it for
request.user
and not for other users, and ideally, we'd want it directly during initial creation of the object (and not later annotated by a middleware).