Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Isolate node_modules inside development container/VM #1899

Merged
merged 2 commits into from
Apr 26, 2023

Conversation

richardebeling
Copy link
Member

Attempt to fix #1648.

Would be nice if some of you could test it out -- inside the VM, you should have node_modules, but outside, the folder should simply be empty (or have whatever contents you want it to have)

I will have to test around with the setup a bit more, especially trying to make it break when having node_modules populated both inside and outside the VM. In theory, it should work.

We probably also want to document the docker flags used.

@richardebeling
Copy link
Member Author

richardebeling commented Apr 3, 2023

@niklasmohrin suggested to just use npm's --global flag, but it doesn't work as documented. I've opened an issue with npm. So this is now waiting to see how the issue resolves.

Edit: Seems like the documentation will be removed instead of adding the feature, so we won't be able to use --global mode.

@janno42 janno42 removed their assignment Apr 24, 2023
@niklasmohrin
Copy link
Member

Works on my machine, although its a bit odd that I still get the empty node_modules on the host machine. Still, this is definitely better than the setup-as-admin we currently have 👍

@richardebeling richardebeling merged commit df3915f into e-valuation:main Apr 26, 2023
@richardebeling richardebeling deleted the isolate-node-modules branch April 26, 2023 12:02
Kakadus pushed a commit to Kakadus/EvaP that referenced this pull request May 8, 2023
FSadrieh pushed a commit to FSadrieh/EvaP that referenced this pull request Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

VM provisioning fails on windows hosts because symlinks can not be created
4 participants