Isolate node_modules inside development container/VM #1899
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to fix #1648.
Would be nice if some of you could test it out -- inside the VM, you should have
node_modules
, but outside, the folder should simply be empty (or have whatever contents you want it to have)I will have to test around with the setup a bit more, especially trying to make it break when having
node_modules
populated both inside and outside the VM. In theory, it should work.We probably also want to document the docker flags used.