Add configurable startpage #1990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardebeling
approved these changes
Aug 28, 2023
niklasmohrin
requested changes
Aug 28, 2023
niklasmohrin
reviewed
Sep 4, 2023
evap/evaluation/models.py
Outdated
Comment on lines
1845
to
1847
| return [self.is_student, self.is_responsible_or_contributor_or_delegate, self.is_grade_publisher].count( | ||
| True | ||
| ) > 1 |
There was a problem hiding this comment.
Could a user lose their status as for example "student" and then be unable to update their startpage? In addition I think this should also be "participant" instead of student (and maybe the other thing is not a problem anymore then?)
In general, maybe we should have can_visit_student_index etc to not have this knowledge duplicated? (Sorry for the general scope bleed :/ )
There was a problem hiding this comment.
i didn't implement anything like can_visit_student_index because this might get even more confusing when thinking about staff mode.
richardebeling
approved these changes
Sep 5, 2023
niklasmohrin
approved these changes
Sep 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1742; make start page configurable