Fix infobox collapse #2237
Fix infobox collapse #2237
Conversation
evap/static/ts/src/infobox.ts
Outdated
| @@ -6,6 +6,7 @@ export class InfoboxLogic { | |||
| private readonly infobox: HTMLDivElement; | |||
| private readonly closeButton: HTMLButtonElement; | |||
| private readonly storageKey: string; | |||
| private timeout?: NodeJS.Timeout; | |||
There was a problem hiding this comment.
This seems odd, we are not targetting node, so the inferred type should be a browser timeout, not a nodejs one. Do we have typescript misconfigured somewhere? 🤔
There was a problem hiding this comment.
okay: by default, tsc imports all @types/* into the global namespace. As we have @types/node because of jest, this works here.
If I excluded the jest types (and thereby node's types) this compiles with number but compilation of the ts tests fail, see e501844
There was a problem hiding this comment.
Ah, okay. According to this, using window.setTimeout (or the returntype trick they use) could work - if not, we can come back to this later
There was a problem hiding this comment.
now it works! Adding it to tsconfig.compile.json should work!
Kakadus
force-pushed
the
fix-infobox-collapse
branch
from
fe81587 to
b292222
Compare
fixes a bug, when the info box is closed during opening of the infobox. Now, we hard abort the opening process and further clear the "opening" timeout to prevent the class to be removed unexpectedly.