More plugin class optimization

e107inc · Jan 13, 2019 · 4becf60 · 4becf60
1 parent c63574c
commit 4becf60
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 4 deletions.
diff --git a/e107_handlers/plugin_class.php b/e107_handlers/plugin_class.php
@@ -101,6 +101,8 @@ function __construct()
 
 		if(empty($this->_ids))
 		{
+		//	e107::getDebug()->log("Running e_plugin::_initIDs()");
+		//	e107::getDebug()->log(debug_backtrace(DEBUG_BACKTRACE_IGNORE_ARGS));
 			$this->_initIDs();
 		}
 
@@ -517,11 +519,15 @@ private function _initIDs()
 				$path = $row['plugin_path'];
 				$this->_ids[$path] = (int) $row['plugin_id'];
 
-				if(!empty($row['plugin_installflag']) && !isset($pref[$path]))
+				if(!empty($row['plugin_installflag']) )
 				{
 					$this->_installed[$path] = $row['plugin_version'];
-					$cfg->setPref('plug_installed/'.$path, $row['plugin_version']);
-					$save = true;
+
+					if(!isset($pref[$path]))
+					{
+						$cfg->setPref('plug_installed/'.$path, $row['plugin_version']);
+						$save = true;
+					}
 				}
 
 				$this->_addons[$path] = !empty($row['plugin_addons']) ? explode(',',$row['plugin_addons']) : null;// $path;

diff --git a/e107_handlers/pref_class.php b/e107_handlers/pref_class.php
@@ -585,7 +585,11 @@ public function save($from_post = true, $force = false, $session_messages = null
 					{
 						if(!$disallow_logs) $log->logMessage('Backup of <strong>'.$this->alias.' ('.$this->prefid.')</strong> successfully created.', E_MESSAGE_DEBUG, E_MESSAGE_SUCCESS, $session_messages);
 						e107::getCache()->clear_sys('Config_'.$this->alias.'_backup');
-						e107::getDebug()->log(debug_backtrace(DEBUG_BACKTRACE_IGNORE_ARGS,2));
+						if(deftrue('e_DEBUG'))
+						{
+							$backtrace = debug_backtrace(DEBUG_BACKTRACE_IGNORE_ARGS,2);
+							$log->logMessage(print_a($backtrace,true),  E_MESSAGE_DEBUG);
+						}
 					}
 
 				}