Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to install plugins or themes via admin web interface.... #1712

Closed
rica-carv opened this issue Jun 17, 2016 · 45 comments
Closed

Unable to install plugins or themes via admin web interface.... #1712

rica-carv opened this issue Jun 17, 2016 · 45 comments
Assignees
Labels
status: testing required Someone needs to confirm this issue's existence and write a test to prevent the fix from regressing. type: bug A problem that should not be happening
Milestone

Comments

@rica-carv
Copy link
Contributor

rica-carv commented Jun 17, 2016

I'm having a "Can't continue" error when i try to install plugins or themes via the web interface on the admin area....
Any ideas what might be causing it???

@CaMer0n
Copy link
Member

CaMer0n commented Jun 18, 2016

What's the exact error message?

@TurBoss
Copy link

TurBoss commented Jun 18, 2016

same here cant install themes or plugins via web
no more info is shown

@rica-carv
Copy link
Contributor Author

rica-carv commented Jun 18, 2016

Plugin download area, in portuguese (go figures, dialog header is in english....):untitled 1

My theme download area gives a diferent info, it reverts back to the admin theme page inside the dialog.....
untitled 2

@Jimmi08
Copy link
Contributor

Jimmi08 commented Jun 18, 2016

Maybe this is related:
I can't update from github on localhost :
image

Plugins, Themes:
image

@rica-carv
Copy link
Contributor Author

@Jimmi08 Perhaps it is, but my images are from a live site, not localhost, so....

@tgtje
Copy link
Contributor

tgtje commented Jun 19, 2016

Just checked too, syncing is fine, themes and plugins is Error : Unable to continue; this is what debugger mentions (no indication why it is happening as i can see (php 7.0.7) LIVE

Warning Declaration of e_tree_model::load($force = false) should be compatible with e_front_model::load($id = NULL, $force = false), Line 3445 of /home/domain/public_html/e107_handlers/model_class.php

Warning Declaration of e_front_tree_model::update($field, $value, $ids, $syncvalue = NULL, $sanitize = true, $session_messages = false) should be compatible with e_tree_model::update($from_post = true, $force = false, $session_messages = false), Line 3579 of /home/domain/public_html/e107_handlers/model_class.php

Warning Declaration of e_pref::update($pref_name, $value) should be compatible with e_front_model::update($from_post = true, $force = false, $session_messages = false), Line 28 of /home/domain/public_html/e107_handlers/pref_class.php

@CaMer0n CaMer0n self-assigned this Jun 19, 2016
@CaMer0n CaMer0n added the type: bug A problem that should not be happening label Jun 20, 2016
@CaMer0n CaMer0n added this to the e107 v2.1.2 milestone Jun 20, 2016
@rica-carv
Copy link
Contributor Author

Sorry, but seems this bug is back again...
Donne a github update 5 min ago, and still unable to install plugins online, it still gives the same error...

@Moc Moc reopened this Jul 15, 2016
@Moc
Copy link
Member

Moc commented Oct 4, 2016

@rica-carv Please try the latest files and see if the issue still occurs.

@Moc Moc removed this from the e107 v2.1.2 milestone Oct 23, 2016
@rica-carv
Copy link
Contributor Author

@Moc Sorry for the delay.
Latest e107 github files, now gives this "errors":
untitled 1
untitled 2
untitled 3

All V2 plugins don't work, some v1.x work, others no....

@Moc Moc added this to the e107 v2.1.2 milestone Oct 24, 2016
@CaMer0n
Copy link
Member

CaMer0n commented Oct 24, 2016

I just tested by downloading Links 2.2 and Userlanguage Flags Menu. They both worked for me.

@tgtje
Copy link
Contributor

tgtje commented Oct 25, 2016

Just found out : please look inside the system folder ; folder (date/code),backup..
The files that are involved (no root folder, found some that do it) ) are downloaded as .zip (no name).
Tested it on a php 7 and php 5 local system. In regards to prev post > cookie consent does work...PGL 0.2 does identical (no root folder) Reason garbled (non utf code) unknown...

@rica-carv
Copy link
Contributor Author

@CaMer0n Indeed, download via admin UI both plugins from @Jimmi08 works.
But it seems that after download, they're nowhere to be found on the installed or not installed page...
They're put on the plugins folder, but not listed in any page on the admin ui plugin management area...

Anyway, have you tried to download Cookie Consent 1.0 or Personal Game Libray 0.2??

@tgtje Just checked my e107_system/backup, and there's only two files there: links_page.zip & userlanguage_flags_menu.zip. The two plugins @CaMer0n also sucessfully downloaded and installed.
I've got nothing more there....

@tgtje
Copy link
Contributor

tgtje commented Oct 25, 2016

pgl 02 gives me the .zip file, and a former e107wiki also..Just checked my live server : yes there too...
Just an idea for the garbled text... as you may notice (looks to me that way) are both error pageviews identical.. Looking at ok (green) bar : 2 langs in use : maybe the error notice is not translated yet ???

@Moc Moc added the status: testing required Someone needs to confirm this issue's existence and write a test to prevent the fix from regressing. label Oct 26, 2016
@rica-carv
Copy link
Contributor Author

@tgtje The two languages in the green bar might be that some lans are not translated yet, and are still in english in the other language (in this case, portuguese) files in english yet....

Further more, sometimes instead of the portuguese or english translation i get the LAN constant name itself, wich is kind of ankwards.....

@tgtje
Copy link
Contributor

tgtje commented Oct 27, 2016

@rica-carv Nope not awkward... when syncing files are updated (new lan goes with them) but iff not present : the code is read and displayed... (assuming it happens in portuguese) if in english..... ? something old is somewhere active..(should not be); or a file worked on eg not in commit stage; LAN added in core file) with no EN support.. As always (at least very often) language (mis-) correctness can cause a lot of issues.

@rica-carv
Copy link
Contributor Author

@tgtje For nonexisting translated LANs, it should default to base english language LAN definition. Not show the LAN name itself....
It would be better, and more user-friendly...
Now if LAN's are by default not defined on the English language, then something is wrong, no?

@Jimmi08
Copy link
Contributor

Jimmi08 commented Oct 27, 2016

@rica-carv you need to set if use English lang if strings are not defined. If not, you will see LAN strings.

@CaMer0n CaMer0n modified the milestones: e107 v2.1.2, e107 v2.1.3 Oct 27, 2016
@CaMer0n
Copy link
Member

CaMer0n commented Oct 28, 2016

@rica-carv Does Language > Preferences > "Load language files only for current language" help?

@CaMer0n
Copy link
Member

CaMer0n commented Oct 31, 2016

@rica-carv @tgtje This is getting confusing. Let's stick to the topic in the heading. Please create a separate issue for the LANs displaying.

Now, back to the issue. Please re-test with DEBUG enabled - it will use a different unzipping method.

@MikeyGMT
Copy link
Contributor

MikeyGMT commented Nov 7, 2016

Do I recall correctly - should we not have to entering an e107.org username and password pref somewhere on our site?
Come to think of it think my e107.org user was disabled some time back when I wasn't around often. Can't search the old forums etc.... is this related?
Do core Devs still have access to e107.org and therefore can download, where as expired / new folk get Unable to Continue?
Indeed adding this line before line 53 of e_marketplace confirms that there we stop after no password
e107::getMessage()->addDebug("No User or Password Supplied");

public function generateAuthKey($username, $password)
    {
        if(trim($username) == '' || trim($password) == '')
        {
e107::getMessage()->addDebug("No User or Password Supplied");
            return false;   
        }
        $this->setAuthKey($this->makeAuthKey($username, $password, true));  
        return $this;
    }

@MikeyGMT
Copy link
Contributor

MikeyGMT commented Nov 8, 2016

Hi @CaMer0n
I have added some debugging as via extra echo statements (debug wasn't playing #2013)
My suspicion is that the there is not enough information to download Consent Plugin from e107.org.
Maybe I have blocked myself from the site as I have done a couple of days of testing/debugging.
Thanks
Mike

Plugin Manager Download Debug.pdf

@CaMer0n
Copy link
Member

CaMer0n commented Nov 8, 2016

@MikeyGMT Thanks. Authentication isn't required. If you were blocked then e107.org should not load for you at all? Please check the e107_system temp folder for any downloads. This error can occur when the unzip wasn't possible.

@MikeyGMT
Copy link
Contributor

Hi All,
I'm still debugging.
For the sites when plugin download/install works, which adaptor is being used... is it fallback xmlrpc method?
My site selects the e_marketplace_adapter_wsdl - where it does not work.
Thanks
Mike

@MikeyGMT
Copy link
Contributor

Hi All,
I have got "Find Plugins > Download and Install from e107.org" working fully now on two of my websites. Quite a lot of fixes are needed so I need to take care I don't break anything.
What I would like to know is, per my earlier post, does this function work at all for anyone?
Thanks
Mike

@Moc
Copy link
Member

Moc commented Nov 17, 2016

@MikeyGMT Not working for me on a live installation (latest git, PHP 5.6)

@CaMer0n
Copy link
Member

CaMer0n commented Nov 17, 2016

@MikeyGMT I believe it's going to be different for everyone depending on the modules installed.

MikeyGMT added a commit to MikeyGMT/e107 that referenced this issue Nov 17, 2016
Fixes e107inc#1712 Plugin Download and Install from Market
@MikeyGMT
Copy link
Contributor

Testing image

@MikeyGMT
Copy link
Contributor

Please can several folk download and test locally before this is accepted.

@MikeyGMT
Copy link
Contributor

image

@MikeyGMT
Copy link
Contributor

MikeyGMT commented Nov 17, 2016

Checking Theme download. Not working. Did that work for anyone, for me I don't think it did?

@CaMer0n
Copy link
Member

CaMer0n commented Nov 18, 2016

@MikeyGMT theme download is working here for me. (local machine) - without your changes.
Let's discuss in real-time before losing more time on this.

CaMer0n added a commit that referenced this issue Nov 19, 2016
…g data added and ampersand modified on URL.
@CaMer0n
Copy link
Member

CaMer0n commented Nov 19, 2016

@rica-carv @tgtje @MikeyGMT @TurBoss Please update your files and let me know if anything improved with this issue. Thanks.

@MikeyGMT
Copy link
Contributor

Hi @CaMer0n
Thanks .. test result with latest git.
image
Thanks
Mike

@rica-carv
Copy link
Contributor Author

Using Firefox, when trying to download plugins, it simply displays the modal with the download circle animation, and keeps on with that. On & on & on....
Might still be bugged...

@CaMer0n
Copy link
Member

CaMer0n commented Nov 21, 2016

@MikeyGMT I traced the problem on your machine to the suhosin 512 char limit on $_GET strings.
See here: http://stackoverflow.com/questions/7724270/max-size-of-url-parameters-in-get

I have limited the amount of data sent via $_GET to avoid hitting this limit.
Commit coming shortly.
I assume the same will need to be applied to the theme download area.

CaMer0n added a commit that referenced this issue Nov 21, 2016
@CaMer0n
Copy link
Member

CaMer0n commented Nov 21, 2016

@rica-carv Was it behaving like this for you before the recent changes?

@rica-carv
Copy link
Contributor Author

@CaMer0n No, before was giving me the error i reported before, up thread (all garbled output).
I'll do another a test later today, ok?
P.S.: I'm testing it on a localhost server, might it be the problem?

@Moc
Copy link
Member

Moc commented Nov 21, 2016

@CaMer0n Updated to latest Git. Plugin download working now (need to hit 'refesh' button to scan for changes in the plugin directories). Theme download is not working, opens up a modal with an iframe, I think, showing the admin area.

@MikeyGMT
Copy link
Contributor

I found that the code is trying to install after download, but as the plugin directory was not scanned after the successful download, the folder is not found in the database, which is needed by the call to install.

Adding the following pluginCheck line after line 721 loads the new plugin into the db and then the plugin is installed well.

if($mp->download($data['plugin_id'], $data['plugin_mode'], 'plugin'))
{
$this -> pluginCheck(true); // rescan the plugin directory
$text = e107::getPlugin()->install($data['plugin_folder']); 

image

@CaMer0n
Copy link
Member

CaMer0n commented Nov 21, 2016

@MikeyGMT Thanks for that. Added it. @rica-carv Make sure e_DEBUG === false. (check your e107_config.php file, and also the e107-debugger plugin is inactive) , also clear your e107_system/--hash--/temp folder.
Theme downloads should be working now also. ( @Moc )

@rica-carv
Copy link
Contributor Author

rica-carv commented Nov 22, 2016

@CaMer0n Latest github installed, as today. Caches clear & temp folders also.
Plugins v2.x: OK...
Plugins v1.x: Still garbled output, as reported above...
Themes: OK...

CaMer0n added a commit that referenced this issue Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: testing required Someone needs to confirm this issue's existence and write a test to prevent the fix from regressing. type: bug A problem that should not be happening
Projects
None yet
Development

No branches or pull requests

7 participants