Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Extended User Rich Text #1775

Closed
LaocheXe opened this issue Jul 10, 2016 · 5 comments
Closed

Feature Request: Extended User Rich Text #1775

LaocheXe opened this issue Jul 10, 2016 · 5 comments
Assignees
Labels
type: enhancement An improvement or new feature request
Milestone

Comments

@LaocheXe
Copy link
Member

LaocheXe commented Jul 10, 2016

So there is a Textarea, but no Rich Text selection, trying to create a user bio but Textarea lacks the TnyMic and BB Code

@Moc Moc added type: enhancement An improvement or new feature request status: testing required Someone needs to confirm this issue's existence and write a test to prevent the fix from regressing. labels Jul 15, 2016
@CaMer0n
Copy link
Member

CaMer0n commented Jul 16, 2016

$frm->bbarea()?

@LaocheXe
Copy link
Member Author

capture1

capture2

untitled-1

@Moc Moc removed the status: testing required Someone needs to confirm this issue's existence and write a test to prevent the fix from regressing. label Jul 17, 2016
@Moc Moc added this to the e107 2.1.8 milestone Feb 28, 2018
@CaMer0n CaMer0n modified the milestones: e107 2.1.8, e107 2.1.9 Jul 18, 2018
@CaMer0n CaMer0n modified the milestones: e107 2.1.9, e107 2.2.0 Aug 22, 2018
@CaMer0n CaMer0n self-assigned this Sep 8, 2018
@Moc Moc assigned Moc and unassigned CaMer0n Jan 31, 2019
@Moc
Copy link
Member

Moc commented Feb 1, 2019

@CaMer0n This needs updating:

return "<textarea id='{$fid}' {$include} name='{$fname}' {$required} {$title}>{$curval}</textarea>";

I'm afraid to change it because of backwards compatibility with fields already using the textarea now. Especially with the 'Field include text' (advanced tab when creating a new EUF).

Another option is to just add add a new type "bbarea" which can be selected when creating a new EUF. That would avoid any BC issues. What do you think? If that's ok with you, I'll add it in.

@Moc Moc modified the milestones: e107 2.2.0, Future Feb 1, 2019
Moc added a commit that referenced this issue Jun 8, 2019
Initial commit. Needs testing as saving linebreaks is not working properly yet. Perhaps due to filter in /usersettings.php.
@CaMer0n CaMer0n modified the milestones: Future, e107 2.2.2 Jun 8, 2019
@CaMer0n
Copy link
Member

CaMer0n commented Jun 8, 2019

@Moc This should be working now.

Moc added a commit that referenced this issue Jun 8, 2019
@Moc
Copy link
Member

Moc commented Jun 8, 2019

Done some testing with @CaMer0n and it is now working like it should.

@LaocheXe Three years later, but it is implemented haha :)

@Moc Moc closed this as completed Jun 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement An improvement or new feature request
Projects
None yet
Development

No branches or pull requests

3 participants