Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i have problem when other websites open my website in iframe #3101

Closed
marceil5 opened this issue Apr 20, 2018 · 12 comments
Closed

i have problem when other websites open my website in iframe #3101

marceil5 opened this issue Apr 20, 2018 · 12 comments
Labels
Help Wanted topic: documentation type: enhancement An improvement or new feature request
Milestone

Comments

@marceil5
Copy link

when news aggregator add my website using ifram to show my news then a blank page apear no news and the rss of my site is correct but what is the problem ??when news aggregator website add my website news directly to their databse there is no problem??please help me with this??

@Jimmi08
Copy link
Contributor

Jimmi08 commented Apr 22, 2018

It's maybe related to this:
Refused to display xxx in a frame because it set 'X-Frame-Options' to 'sameorigin'.
Check your console (F12 in chrome, second tab), if this is it.
It was changed sometimes ago.
I was sure it was my issue about this, but maybe I asked only on gitter.

@marceil5
Copy link
Author

Solved i omit SAMORGIN header

@Jimmi08
Copy link
Contributor

Jimmi08 commented Apr 28, 2018

@marceil5 could you explain what did you do? Where do you omit that header?

@marceil5
Copy link
Author

marceil5 commented May 1, 2018

open class2.php and search for the bellow code and add // to the code
$this->setHeader('X-Frame-Options: SAMEORIGIN'); so it become like the following
//$this->setHeader('X-Frame-Options: SAMEORIGIN');
it wil work fine

@Jimmi08
Copy link
Contributor

Jimmi08 commented May 1, 2018

Oh, so you changed core files. I hoped you found different way. I was looking for solution without it. Maybe this should be in preferencies. It wasn't this way before.

@Moc
Copy link
Member

Moc commented May 10, 2018

@CaMer0n Is this an intentional security/privacy measure?

@CaMer0n
Copy link
Member

CaMer0n commented May 10, 2018

@Moc Yes, perhaps we can add a flag inside e107_config.php to disable it for people who need that option.

@Moc Moc added type: enhancement An improvement or new feature request topic: documentation labels Jun 23, 2018
@Moc Moc added this to the e107 2.1.9 milestone Jun 23, 2018
@Jimmi08
Copy link
Contributor

Jimmi08 commented Aug 3, 2018

This starts to be a bit annoying. You can't use heat maps without changing core file.

Why this is not part .htaccess anymore? Or set it as prefs.

CaMer0n added a commit that referenced this issue Aug 4, 2018
@CaMer0n
Copy link
Member

CaMer0n commented Aug 4, 2018

A pull-request is always welcome @Jimmi08. ;-) Not a complicated fix if you check the changes.

@CaMer0n CaMer0n modified the milestones: e107 2.1.9, e107 2.2.0 Aug 22, 2018
@Moc Moc modified the milestones: e107 2.2.0, Future Feb 1, 2019
@Moc
Copy link
Member

Moc commented Feb 1, 2019

Closing, still requires documentation (tracked in Documentation project)

@Moc Moc closed this as completed Feb 1, 2019
@CaMer0n
Copy link
Member

CaMer0n commented Feb 1, 2019

@Moc I think we should add all these flags into e107_config.php when it is generated during install. Even though not enabled, it will educate as to what can be configured this way.

Moc added a commit that referenced this issue Feb 9, 2019
@Moc
Copy link
Member

Moc commented Feb 9, 2019

@CaMer0n I added some but there may be more to add

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Help Wanted topic: documentation type: enhancement An improvement or new feature request
Projects
Status: Backlog
Development

No branches or pull requests

4 participants