Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emailprint button templatization #5391

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

rica-carv
Copy link
Contributor

@rica-carv rica-carv commented Jan 15, 2025

Motivation and Context

Suggested option to fully allow templatization of buttons, either bootstrap output or not. Buttons can be rendered as A tags or BUTTON tags, and the HTML hardcoded inside the PHP makes the customization a lot harder than with templates. Templates can even allow the templatization at theme level, much easier without rewriting the whole PHP code to have a custom button, like for instance, with text besides icon....
If approved, this can also be the starting point of allowing templatization of e107 buttons, etc....

Even better, this code is only currently used in news, but it can be used also in forum, etc., to allow a standardization of layouts sitewide....
Just my 2 cents...

Description

Changed hardcoded HTML to a new template, and leave old code for legacy purposes commented.

How Has This Been Tested?

Tested in last github e107 code

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (a change to man pages or other documentation)

Checklist

Copy link

codeclimate bot commented Jan 15, 2025

Code Climate has analyzed commit ce99d9e and detected 4 issues on this pull request.

Here's the issue category breakdown:

Category Count
Bug Risk 4

The test coverage on the diff in this pull request is 85.1% (80% is the threshold).

This pull request will bring the total coverage in the repository to 39.0%.

View more on Code Climate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant