Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forum breadcrumb shortcode update #5413

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

rica-carv
Copy link
Contributor

@rica-carv rica-carv commented Jan 28, 2025

Motivation and Context

Render breadcrumbs as they are suppossed to be rendered in V2.x
Now there's a global breadcrumb shortcode {---BREADCRUMB---}, that has the exact same output as these forum spread shortcodes

Description

Changed the output of the whole forum breadcrumb shortcodes to display the correct outputed breadcrumb

How Has This Been Tested?

Tested with latest github e107 files

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (a change to man pages or other documentation)

Checklist

Copy link

codeclimate bot commented Jan 28, 2025

Code Climate has analyzed commit abae96c and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 60.0% (80% is the threshold).

This pull request will bring the total coverage in the repository to 38.8% (-0.2% change).

View more on Code Climate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant