address PR comments

e2b-dev · Jan 18, 2025 · 06ef257 · 06ef257
1 parent 7cc525e
commit 06ef257
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 13 deletions.
diff --git a/packages/js-sdk/tests/sandbox/commands/sendStdin.test.ts b/packages/js-sdk/tests/sandbox/commands/sendStdin.test.ts
@@ -1,13 +1,12 @@
 import { assert } from 'vitest'
-import { sandboxTest, wait } from '../../setup.js'
+import { sandboxTest } from '../../setup.js'
 
 sandboxTest('send stdin to process', async ({ sandbox }) => {
   const text = 'Hello, World!'
   const cmd = await sandbox.commands.run('cat', { background: true })
 
   await sandbox.commands.sendStdin(cmd.pid, text)
 
-
   for (let i = 0; i < 5; i++) {
     if (cmd.stdout === text) {
       break
@@ -37,8 +36,6 @@ sandboxTest('send special characters to stdin', async ({ sandbox }) => {
 
   await sandbox.commands.sendStdin(cmd.pid, text)
 
-  await wait(5_000)
-
   for (let i = 0; i < 5; i++) {
     if (cmd.stdout === text) {
       break
@@ -66,6 +63,5 @@ sandboxTest('send multiline string to stdin', async ({ sandbox }) => {
 
   await cmd.kill()
 
-
   assert.equal(cmd.stdout, text)
 })
diff --git a/packages/js-sdk/tests/sandbox/host.test.ts b/packages/js-sdk/tests/sandbox/host.test.ts
@@ -10,11 +10,20 @@ sandboxTest.skipIf(isDebug)(
     })
 
     try {
-      await wait(10_000)
+      await wait(1000)
 
       const host = sandbox.getHost(8000)
 
-      const res = await fetch(`${isDebug ? 'http' : 'https'}://${host}`)
+      let res = await fetch(`${isDebug ? 'http' : 'https'}://${host}`)
+
+      for (let i = 0; i < 10; i++) {
+        if (res.status === 200) {
+          break
+        }
+
+        res = await fetch(`${isDebug ? 'http' : 'https'}://${host}`)
+        await wait(500)
+      }
 
       assert.equal(res.status, 200)
     } finally {
@@ -35,17 +44,16 @@ sandboxTest.skipIf(isDebug)(
     })
 
     try {
-      await wait(10_000)
+      const host = sandbox.getHost(49983)
+      const url = `${isDebug ? 'http' : 'https'}://${host}/health`
 
-      const host = sandbox.getHost(8000)
-
-      const res = await fetch(`${isDebug ? 'http' : 'https'}://${host}`)
+      const res = await fetch(url)
 
-      assert.equal(res.status, 200)
+      assert.equal(res.status, 204)
 
       await sandbox.kill()
 
-      const res2 = await fetch(`${isDebug ? 'http' : 'https'}://${host}`)
+      const res2 = await fetch(url)
       assert.equal(res2.status, 502)
 
       const text = await res2.text()