fix VersionedNavGroup missing type

e2b-dev · Nov 26, 2024 · 3d15a60 · 3d15a60
1 parent b3d5457
commit 3d15a60
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 7 deletions.
diff --git a/apps/web/src/components/Navigation/NavigationSubgroup.tsx b/apps/web/src/components/Navigation/NavigationSubgroup.tsx
@@ -1,16 +1,17 @@
-import { useEffect, useState } from 'react'
-import { usePathname } from 'next/navigation'
 import clsx from 'clsx'
 import { ChevronDown, ChevronRight } from 'lucide-react'
+import { usePathname } from 'next/navigation'
+import { useEffect, useState } from 'react'
 
-import { NavSubgroup } from './routes'
 import { NavigationLink } from './NavigationLink'
+import { NavSubgroup } from './routes'
 
 export function NavigationSubgroup({ subgroup }: { subgroup: NavSubgroup }) {
   const [isExpanded, setIsExpanded] = useState(false)
   const pathname = usePathname()
 
-  const isActive = subgroup.links.some(link => link.href === pathname)
+  console.log('subgroup', subgroup)
+  const isActive = subgroup.links.some((link) => link.href === pathname)
 
   // Automatically expand the subgroup if it's active
   useEffect(() => {
@@ -36,7 +37,9 @@ export function NavigationSubgroup({ subgroup }: { subgroup: NavSubgroup }) {
       >
         <div className="flex items-center justify-start gap-1">
           {subgroup.icon}
-          <h3 className="text-sm font-medium group-hover:text-white">{subgroup.title}</h3>
+          <h3 className="text-sm font-medium group-hover:text-white">
+            {subgroup.title}
+          </h3>
         </div>
         {isExpanded ? (
           <ChevronDown className="w-4 h-4 ml-2 text-zinc-400 group-hover:text-white" />

diff --git a/apps/web/src/components/Navigation/index.tsx b/apps/web/src/components/Navigation/index.tsx
@@ -143,7 +143,14 @@ function VersionedNavigationGroup({
           <>
             {group.versionedItems[curVersion]?.map((item) => (
               <React.Fragment key={item.title}>
-                <NavigationSubgroup subgroup={item as NavSubgroup} />
+                {(item as any).links ? (
+                  <NavigationSubgroup subgroup={item as NavSubgroup} />
+                ) : (
+                  <NavigationLink
+                    link={item as NavLink}
+                    className="font-medium"
+                  />
+                )}
               </React.Fragment>
             ))}
           </>

diff --git a/apps/web/src/components/Navigation/routes.tsx b/apps/web/src/components/Navigation/routes.tsx
@@ -22,7 +22,7 @@ export interface NavGroup {
 export interface VersionedNavGroup {
   title?: string
   icon?: React.ReactNode
-  versionedItems: { [key: string]: NavSubgroup[] }
+  versionedItems: { [key: string]: Array<NavLink | NavSubgroup> }
 }
 
 export const docRoutes: NavGroup[] = [