Change exception descriptions; Add TODO comment

e2b-dev · Oct 21, 2024 · aa302ed · aa302ed
1 parent 1e2daa3
commit aa302ed
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/packages/js-sdk/src/sandbox/commands/commandHandle.ts b/packages/js-sdk/src/sandbox/commands/commandHandle.ts
@@ -218,6 +218,7 @@ export class CommandHandle
           }
           break
       }
+      // TODO: Handle empty events like in python SDK
     }
   }
 

diff --git a/packages/python-sdk/e2b/sandbox_async/commands/command_handle.py b/packages/python-sdk/e2b/sandbox_async/commands/command_handle.py
@@ -172,7 +172,7 @@ async def wait(self) -> CommandResult:
             raise self._iteration_exception
 
         if self._result is None:
-            raise Exception("Process ended without an end event")
+            raise Exception("Command ended without an end event")
 
         if self._result.exit_code != 0:
             raise CommandExitException(

diff --git a/packages/python-sdk/e2b/sandbox_sync/commands/command_handle.py b/packages/python-sdk/e2b/sandbox_sync/commands/command_handle.py
@@ -124,7 +124,7 @@ def wait(
             raise self._iteration_exception
 
         if self._result is None:
-            raise Exception("Process ended without an end event")
+            raise Exception("Command ended without an end event")
 
         if self._result.exit_code != 0:
             raise CommandExitException(
-Original file line number
+Diff line change
@@ Expand Up / @@ -218,6 +218,7 @@ export class CommandHandle @@
               }
               break
           }
+          // TODO: Handle empty events like in python SDK
         }
       }
@@ Expand Down @@