Add recursive directory watch #488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 13f0c78 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
0div
previously requested changes
Dec 3, 2024
There was a problem hiding this comment.
Overall this looks good from a code perspective 👍
From a product perspective, do you think it would be better not to make recursive an option and just always watch recursively ? Also taking into account that the instructions said:
Make as few changes to the communication between envd and SDKs as possible
ValentaTomas
added
feature
dobrac
force-pushed
the
watch-dir-recursive
branch
from
666b3d4 to
724e857
Compare
jakubno
requested changes
Dec 19, 2024
jakubno
reviewed
Dec 19, 2024
|
I think the envd part is already merged, right? |
looks like it e2b-dev/infra#233 |
- Removed code runtime version check to prevent issues until further investigation
jakubno
force-pushed
the
watch-dir-recursive
branch
from
f4369e1 to
8c52e73
Compare
jakubno
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds recursive directory watch to the SDK and documentation section. Requires merging and deploying e2b-dev/infra#210 first.
Proposed API change:
JS
Python
Notes
Python SDK was generated using buf.build/protocolbuffers/python:v28.3. The runtime check was removed for now. Further tests might be required to make sure the runtime is at least the generated version before including the runtime check.
Changing the following in the file spec/envd/buf-python.gen.yaml (generator) allows using different protoc-gen-python version:
From:
plugin: pythonTo:
plugin: buf.build/protocolbuffers/python:v28.3