Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix duplicate search analytics event captures #535

Merged
merged 2 commits into from
Jan 13, 2025

Conversation

ben-fornefeld
Copy link
Contributor

This pr adds the following:

  1. prevents unnecessary analytics event captures when user erases query & user navigates through results with arrow keys
  2. changes docs page legacy banner prose (v.1.0 -> v1.0)

@ben-fornefeld ben-fornefeld added bug Something isn't working Improvement Improvement for current functionality dashboard Improvements or additions to dashboard labels Jan 13, 2025
@ben-fornefeld ben-fornefeld self-assigned this Jan 13, 2025
Copy link

linear bot commented Jan 13, 2025

Copy link

changeset-bot bot commented Jan 13, 2025

⚠️ No Changeset found

Latest commit: 8992302

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ben-fornefeld ben-fornefeld merged commit 7f57364 into main Jan 13, 2025
2 checks passed
@ben-fornefeld ben-fornefeld deleted the fix-docs-search-analytics-e2b-1434 branch January 13, 2025 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dashboard Improvements or additions to dashboard Improvement Improvement for current functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants