Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add envd version to SDKs #548

Merged
merged 3 commits into from
Jan 23, 2025
Merged

Add envd version to SDKs #548

merged 3 commits into from
Jan 23, 2025

Conversation

jakubno
Copy link
Member

@jakubno jakubno commented Jan 23, 2025

Description

Add envd version when creating sandbox to allow for check if features are available

@jakubno jakubno requested a review from 0div January 23, 2025 04:58
@jakubno jakubno requested a review from ValentaTomas as a code owner January 23, 2025 04:58
Copy link

changeset-bot bot commented Jan 23, 2025

⚠️ No Changeset found

Latest commit: 323c221

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ValentaTomas
Copy link
Member

What about when we are just reconnecting to the sandbox?

@ValentaTomas ValentaTomas added the Improvement Improvement for current functionality label Jan 23, 2025
@jakubno
Copy link
Member Author

jakubno commented Jan 23, 2025

We need to add endpoint for that, but this is blocking and will end up in merge conflicts if we don't add it

Copy link
Contributor

@0div 0div left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the newly returned -> SandboxCreateResponse: didn't break any tests?

@jakubno
Copy link
Member Author

jakubno commented Jan 23, 2025

why should it?

@0div
Copy link
Contributor

0div commented Jan 23, 2025

why should it?

from memory there are a few tests that re-use the sandbox ID to call other class methods, but maybe they use the property.

@jakubno
Copy link
Member Author

jakubno commented Jan 23, 2025

This was change only in internals

@jakubno jakubno merged commit e3f953d into main Jan 23, 2025
2 checks passed
@jakubno jakubno deleted the add-envd-version branch January 23, 2025 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Improvement for current functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants