-
Notifications
You must be signed in to change notification settings - Fork 489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add envd version to SDKs #548
Conversation
|
What about when we are just reconnecting to the sandbox? |
We need to add endpoint for that, but this is blocking and will end up in merge conflicts if we don't add it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the newly returned -> SandboxCreateResponse:
didn't break any tests?
why should it? |
from memory there are a few tests that re-use the sandbox ID to call other class methods, but maybe they use the property. |
This was change only in internals |
Description
Add envd version when creating sandbox to allow for check if features are available