Manage start command in envd #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ValentaTomas
commented
Jan 29, 2024
|
We may want to rethink the proper way to handle start command — even when we move the management to envd there are questions about storing start command logs and how to handle output subscriptions/reconnecting. |
|
Jupyter + info about starting the sandbox are exported |
jakubno
reviewed
May 21, 2024
What is the format of results/stdout/stderr from the jupyter in the logs? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now the start cmd is managed by systemd. This PR changed it so it is managed by envd which allows us better control over it and also allows integration with logging.
Tasks