This repository has been archived by the owner on Aug 1, 2019. It is now read-only.
Migrated to Swift 3 and ASDK 1.9.90 #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atainter
reviewed
Sep 14, 2016
| @@ -6,7 +6,7 @@ target 'nMessenger' do | |||
| use_frameworks! | |||
|
|
|||
| # Pods for nMessenger | |||
| pod 'AsyncDisplayKit', '1.9.80' | |||
| pod 'AsyncDisplayKit' | |||
|
|
|||
There was a problem hiding this comment.
Can we keep this at 1.9.90? I want to avoid issues like the 1.9.81 we had earlier.
| @@ -133,5 +133,5 @@ NMessenger is a fast, lightweight messenger component built on AsyncDisplaykit a | |||
| s.requires_arc = true | |||
|
|
|||
| # s.xcconfig = { "HEADER_SEARCH_PATHS" => "$(SDKROOT)/usr/include/libxml2" } | |||
| s.dependency "AsyncDisplayKit", "1.9.80" | |||
| s.dependency "AsyncDisplayKit" | |||
| end | |||
atainter
reviewed
Sep 14, 2016
| fileprivate func waitForMessageLock(_ completion: @escaping ()->Void) { | ||
| //DispatchQueue.global(priority: DispatchQueue.GlobalQueuePriority.default).async { | ||
|
|
||
| DispatchQueue.global(qos: DispatchQoS.QoSClass.default).async { |
There was a problem hiding this comment.
This can also be DispatchQueue.global().async {}. (qos' default value is ´DispatchQoS.QoSClass.default`) I'd prefer this since it is a bit cleaner.
| messengerNode.frame = self.bounds | ||
| messengerNode.view.separatorStyle = UITableViewCellSeparatorStyle.None | ||
| messengerNode?.frame = self.bounds | ||
| messengerNode?.view.separatorStyle = UITableViewCellSeparatorStyle.none |
There was a problem hiding this comment.
Why is messengerNode an optional now? I'd prefer to fix this since it ripples down to so many functions.
| } | ||
| } | ||
|
|
||
| //run this on a background thread | ||
| dispatch_async(dispatch_get_global_queue(DISPATCH_QUEUE_PRIORITY_DEFAULT, 0)) { | ||
| DispatchQueue.global(qos: DispatchQoS.QoSClass.default).async { |
DavidSchechter
force-pushed
the
master
branch
from
9e8d3ce to
8f8733e
Compare
Changes according to @atainter comments Removed cocoapod junk and edited readme
DavidSchechter
force-pushed
the
master
branch
from
4a96fc8 to
0256f5f
Compare
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@atainter