Fix to precommit/commit order inversion bug #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Since `peer::set_free()` is called prior than response handler without acquiring `raft_server::lock_`, there can be an edge case that leader may send duplicate logs, and their last log index may not be greater than the last log index this server already has. We should always compare the target index with current precommit index, and take it only when it is greater than the previous one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
peer::set_free()is called prior than response handlerwithout acquiring
raft_server::lock_, there can be an edge casethat leader may send duplicate logs, and their last log index may not
be greater than the last log index this server already has. We should
always compare the target index with current precommit index, and take
it only when it is greater than the previous one.