Update sm_commit_index_ after state_machine commit is called. #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greensky00
reviewed
Jan 13, 2020
include/libnuraft/raft_server.hxx
Outdated
| @@ -572,8 +572,8 @@ protected: | |||
| void commit_in_bg(); | |||
| void append_entries_in_bg(); | |||
|
|
|||
| void commit_app_log(ptr<log_entry>& le, bool need_to_handle_commit_elem); | |||
| void commit_conf(ptr<log_entry>& le); | |||
| void commit_app_log(ptr<log_entry>& le, bool need_to_handle_commit_elem, ulong sm_committing_index); | |||
There was a problem hiding this comment.
Please don't exceed 90 chars per line.
src/handle_commit.cxx
Outdated
| } | ||
|
|
||
| sm_commit_index_ = sm_committing_index; |
There was a problem hiding this comment.
To be safe, we should use compare-and-swap here.
greensky00
approved these changes
Jan 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.