Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[breaking] Remove deprecated stuff #117

Merged
merged 6 commits into from
Oct 11, 2022
Merged

[breaking] Remove deprecated stuff #117

merged 6 commits into from
Oct 11, 2022

Conversation

darkwebdev
Copy link
Collaborator

@darkwebdev darkwebdev commented Oct 7, 2022 •
edited
Loading

Fixes #66

@darkwebdev darkwebdev added this to the v2.x milestone Oct 7, 2022
@darkwebdev darkwebdev requested a review from abiyasa October 7, 2022 14:56
@darkwebdev darkwebdev linked an issue Oct 7, 2022 that may be closed by this pull request
Remove deprecated stuff before releasing. #113
Closed
@darkwebdev darkwebdev marked this pull request as draft October 7, 2022 15:11
@darkwebdev darkwebdev marked this pull request as ready for review October 7, 2022 17:58
abiyasa
abiyasa requested changes Oct 10, 2022
View reviewed changes
Copy link
Member

@abiyasa abiyasa left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@darkwebdev Unfortunately you forgot to remove (as stated on issue #66):

  • EbayProgressStep props number, which is replaced by property state.

Other than that, all good 👍

@HenriqueLimas
Copy link
Member

@abiyasa this is being done on #114

@HenriqueLimas HenriqueLimas merged commit 2baf1c2 into 2.0.0 Oct 11, 2022
@HenriqueLimas HenriqueLimas deleted the BREAKING/remove-deprecated branch October 11, 2022 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abiyasa abiyasa abiyasa approved these changes

@HenriqueLimas HenriqueLimas HenriqueLimas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.x
Development

Successfully merging this pull request may close these issues.

Remove deprecated stuff before releasing.
3 participants
@darkwebdev @HenriqueLimas @abiyasa