Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support unique ids on ebay-section #367

Merged
merged 2 commits into from
Oct 7, 2024
Merged

support unique ids on ebay-section #367

merged 2 commits into from
Oct 7, 2024

Conversation

woorea
Copy link
Contributor

@woorea woorea commented Oct 7, 2024

Generate the same id section-notice-information when there are multiple SectionNotices causing invalid HTML and duplicate-id-aria on accessibility tools

HenriqueLimas
HenriqueLimas requested changes Oct 7, 2024
View reviewed changes
Copy link
Member

@HenriqueLimas HenriqueLimas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! That is great, just that we need to consider that some applications internally still uses React 16, so we need to make sure we don't break on their side

src/ebay-section-notice/section-notice.tsx Outdated Show resolved Hide resolved
@HenriqueLimas HenriqueLimas merged commit 9a406df into eBay:main Oct 7, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HenriqueLimas HenriqueLimas HenriqueLimas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@woorea @HenriqueLimas