Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(EbaySvg): Support list of icons to render #371

Merged
merged 2 commits into from
Oct 16, 2024
Merged

feat(EbaySvg): Support list of icons to render #371

merged 2 commits into from
Oct 16, 2024

Conversation

HenriqueLimas
Copy link
Member

  • Add a new icons array that will render only the necessary icon by the application
  • By default, renders all the icons so we don't introduce a breaking change
  • Change the icon generation script to create the new symbols.tsx file

@HenriqueLimas HenriqueLimas self-assigned this Oct 15, 2024
darkwebdev
darkwebdev approved these changes Oct 16, 2024
View reviewed changes
Copy link
Collaborator

@darkwebdev darkwebdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, thanks!

@darkwebdev darkwebdev linked an issue Oct 16, 2024 that may be closed by this pull request
EbaySvg: allow to include/exclude certain icons #42
Closed
@darkwebdev darkwebdev added the tech debt The update/fix/change is overdue label Oct 16, 2024
shpandian
shpandian approved these changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@shpandian shpandian left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

finally, long pending :) hopefully apps make use of it and let it be in default state.

@HenriqueLimas lets spread the word in the react channel post publish ..

@shpandian shpandian merged commit 7d13ba4 into main Oct 16, 2024
6 checks passed
@shpandian shpandian deleted the hlimas/svg-icons branch October 16, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darkwebdev darkwebdev darkwebdev approved these changes

@shpandian shpandian shpandian approved these changes

@abiyasa abiyasa Awaiting requested review from abiyasa

@aaron-nance aaron-nance Awaiting requested review from aaron-nance

@montoya332 montoya332 Awaiting requested review from montoya332

Assignees

@HenriqueLimas HenriqueLimas

Labels
tech debt The update/fix/change is overdue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

EbaySvg: allow to include/exclude certain icons
3 participants
@HenriqueLimas @shpandian @darkwebdev