Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: EbayInfotip focus host on closing infotip #68

Merged
merged 2 commits into from
Aug 15, 2022
Merged

FIX: EbayInfotip focus host on closing infotip #68

merged 2 commits into from
Aug 15, 2022

Conversation

HenriqueLimas
Copy link
Member

  • Add a hostRef on useTooltip and focus on it on collapse

Fix #67

@HenriqueLimas HenriqueLimas self-assigned this Aug 14, 2022
abiyasa
abiyasa approved these changes Aug 14, 2022
View reviewed changes
Copy link
Member

@abiyasa abiyasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

src/common/tooltip-utils/use-tooltip.ts Outdated Show resolved Hide resolved
@HenriqueLimas HenriqueLimas merged commit 7cf9448 into main Aug 15, 2022
@HenriqueLimas HenriqueLimas deleted the hlimas/fix-infotip-focus branch August 15, 2022 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abiyasa abiyasa abiyasa approved these changes

@darkwebdev darkwebdev Awaiting requested review from darkwebdev

@montoya332 montoya332 Awaiting requested review from montoya332

Assignees

@HenriqueLimas HenriqueLimas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Accessibility: Infotip focus on collapse
2 participants
@HenriqueLimas @abiyasa