Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(icon-button): added priority #2156

Merged
merged 1 commit into from
Apr 15, 2024
Merged

feat(icon-button): added priority #2156

merged 1 commit into from
Apr 15, 2024

Conversation

agliga
Copy link
Contributor

@agliga agliga commented Apr 11, 2024

Description

  • Added priority to icon button
  • Updated tests to use storybook and snapshots

References

#2155

Screenshots

Screenshot 2024-04-11 at 9 01 42 AM Screenshot 2024-04-11 at 9 01 46 AM Screenshot 2024-04-11 at 9 01 51 AM

@agliga agliga self-assigned this Apr 11, 2024
Copy link

changeset-bot bot commented Apr 11, 2024

🦋 Changeset detected

Latest commit: a48b760

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@ebay/ebayui-core Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@ArtBlue ArtBlue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks awesome!

@agliga agliga merged commit 3322847 into 13.4.0 Apr 15, 2024
2 checks passed
@agliga agliga deleted the icon-button-priority branch April 15, 2024 19:07
@github-actions github-actions bot mentioned this pull request Apr 15, 2024
@github-actions github-actions bot mentioned this pull request Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants