Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(date-textbox): ensure no breaking changes #2187

Merged
merged 1 commit into from
Jun 6, 2024
Merged

Conversation

LuLaValva
Copy link
Member

Description

  • date-utils was moved during a minor version change, as it was thought to be an internal API, but users were importing from "@ebay/ebayui-core/dist/components/ebay-calendar/date-utils" so it is actually breaking.
  • For this patch, APIs are duplicated until the next major version

@LuLaValva LuLaValva requested a review from agliga June 5, 2024 23:54
@LuLaValva LuLaValva self-assigned this Jun 5, 2024
Copy link

changeset-bot bot commented Jun 5, 2024

🦋 Changeset detected

Latest commit: 2da9293

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@ebay/ebayui-core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@agliga agliga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to undo this in 13.0.0
Please add it to 13.0.0 breaking changes ticket to track

@LuLaValva LuLaValva merged commit b294759 into master Jun 6, 2024
2 checks passed
@LuLaValva LuLaValva deleted the breaking-date-utils branch June 6, 2024 00:08
@github-actions github-actions bot mentioned this pull request Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants