Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(phone-input): use Intl for country names instead of hardcoding #2193

Merged
merged 5 commits into from
Jun 24, 2024

Conversation

LuLaValva
Copy link
Member

@LuLaValva LuLaValva commented Jun 18, 2024

Description

  • With current phone-input, we require bundle to include a list of all country names in a given locale. This is unnecessary because Intl already provides this functionality.

Context

  • A team was unable to make backend changes to get a list of country names, and I realized that they really shouldn't have to because we can use the browser for this instead

Note

  • Previously, it was possible to refrain from including certain countries from the list. This is no longer possible, but I think that is a good change. We should support all country codes.

Screenshots

image image

References

#2197

@LuLaValva LuLaValva requested a review from agliga June 18, 2024 00:12
@LuLaValva LuLaValva self-assigned this Jun 18, 2024
Copy link

changeset-bot bot commented Jun 18, 2024

🦋 Changeset detected

Latest commit: b45cdae

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@ebay/ebayui-core Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@LuLaValva LuLaValva merged commit dac2644 into 14.0.0 Jun 24, 2024
4 checks passed
@LuLaValva LuLaValva deleted the localized-phone-input branch June 24, 2024 16:30
This was referenced Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants