Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(textbox): prefix & postfix #2200

Merged
merged 4 commits into from
Jun 26, 2024
Merged

feat(textbox): prefix & postfix #2200

merged 4 commits into from
Jun 26, 2024

Conversation

LuLaValva
Copy link
Member

Important

Description

  • Add @prefix-text and @postfix-text
  • Move class names into the parent textbox
  • Include focus and blur event handlers, to be removed after full support for :has

Screenshots

image

@LuLaValva LuLaValva requested a review from agliga June 24, 2024 21:20
@LuLaValva LuLaValva self-assigned this Jun 24, 2024
Copy link

changeset-bot bot commented Jun 24, 2024

🦋 Changeset detected

Latest commit: 353a9b1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@ebay/ebayui-core Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@LuLaValva LuLaValva changed the title Textbox prefix postfix feat(textbox): prefix & postfix Jun 25, 2024
Copy link
Contributor

@agliga agliga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good.
One minor comment

I will approve after the skin PR is merged.

package.json Outdated Show resolved Hide resolved
@agliga agliga merged commit 2cbba20 into 14.0.0 Jun 26, 2024
4 checks passed
@agliga agliga deleted the textbox-prefix-postfix branch June 26, 2024 15:10
This was referenced Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants