Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(listbox-button): added postfix-label #2202

Merged
merged 2 commits into from
Jun 26, 2024
Merged

feat(listbox-button): added postfix-label #2202

merged 2 commits into from
Jun 26, 2024

Conversation

agliga
Copy link
Contributor

@agliga agliga commented Jun 25, 2024

Description

  • Added postfix-label to listbox
  • Wrapped it in a span because the team needs this to override in order to test their gold standard
  • No documentation added. This is not a pattern we want to expose

References

#2201

Screenshots

Screenshot 2024-06-25 at 11 45 41 AM

@agliga agliga self-assigned this Jun 25, 2024
Copy link

changeset-bot bot commented Jun 25, 2024

🦋 Changeset detected

Latest commit: e60b777

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@ebay/ebayui-core Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@agliga
Copy link
Contributor Author

agliga commented Jun 25, 2024

Seems like formatter changed one of the lines.

@LuLaValva LuLaValva merged commit d535781 into 14.0.0 Jun 26, 2024
4 checks passed
@LuLaValva LuLaValva deleted the listbox-postfix branch June 26, 2024 14:36
This was referenced Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants