Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(calendar): account for timezones with "today" calculation #2246

Merged
merged 2 commits into from
Aug 30, 2024

Conversation

LuLaValva
Copy link
Member

Description

  • Use the local timezone instead of UTC for "today"

Context

  • For testing, you can modify timezone in system settings until your date doesn't match the UTC date. In California during the morning, China Standard Time is a day ahead so I used that.

@LuLaValva LuLaValva requested a review from agliga August 29, 2024 17:00
@LuLaValva LuLaValva self-assigned this Aug 29, 2024
Copy link

changeset-bot bot commented Aug 29, 2024

🦋 Changeset detected

Latest commit: 6df88e8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@ebay/ebayui-core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@LuLaValva LuLaValva changed the base branch from master to 14.2.0 August 29, 2024 17:00
@agliga agliga merged commit 81a3106 into 14.2.0 Aug 30, 2024
4 checks passed
@agliga agliga deleted the 2244-calendar-today branch August 30, 2024 14:35
This was referenced Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ebay-date-textbox: current date circle circles tomorrow
2 participants