Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Venmo icon: Missing borders #2265

Closed
1 task done
HenriqueLimas opened this issue Feb 7, 2024 · 5 comments
Closed
1 task done

Venmo icon: Missing borders #2265

HenriqueLimas opened this issue Feb 7, 2024 · 5 comments
Assignees
Milestone

Comments

@HenriqueLimas
Copy link
Member

I verified there's no existing issue for this bug.

  • There are no existing issues

Current behavior

Venmo doesn't have border as the other payment methods

Screen Shot 2024-02-07 at 11 35 15 AM

Expected behavior

Expectation is that Venmo icon has borders in it

Skin version

17

Device/OS/Browser info

No response

Steps to reproduce

Check Venmo icon on https://opensource.ebay.com/skin/#icon

Relevant code block

No response

Additional context

No response

@ArtBlue
Copy link
Contributor

ArtBlue commented Feb 7, 2024

The icon we originally got was likely missing stroke-width on the rect. The other similar ones that do have the outline visually do have the stroke-width; this one icon does not.

To fix this, we simply need to add stroke-width="1" to the rect to look like this:

<rect x=".5" y=".5" width="49" height="31" rx="1.5" fill="#fff" stroke="#000" stroke-width="1"></rect>

@ratinsl
Copy link

ratinsl commented Feb 7, 2024

@ArtBlue
Here is the zip drive with the venmo assets with the stroke.
240207_venmo_stroke_assets.zip

@ArtBlue
Copy link
Contributor

ArtBlue commented Feb 7, 2024

Thanks, @ratinsl !

@agliga agliga added this to eBayUI Feb 9, 2024
@agliga agliga added this to the 17.2.0 milestone Feb 9, 2024
@agliga agliga moved this to Todo in eBayUI Feb 13, 2024
@ArtBlue ArtBlue self-assigned this Feb 13, 2024
@ArtBlue
Copy link
Contributor

ArtBlue commented Feb 13, 2024

@ratinsl , I downloaded your zip file, and it looks like the stroke-width is still missing from the rect. Maybe whatever export issue caused this, caused the original exclusion?

image

@ArtBlue ArtBlue moved this from Todo to Pull request in eBayUI Feb 13, 2024
@ratinsl
Copy link

ratinsl commented Feb 14, 2024

@ArtBlue updated package with stroke-width added to all. Please test these.
240214_venmo_stroke_assets.zip

@ArtBlue ArtBlue closed this as completed Feb 15, 2024
@ArtBlue ArtBlue moved this from Pull request to Done in eBayUI Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

When branches are created from issues, their pull requests are automatically linked.

4 participants