Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(icon): added missing venmo icon borders #2269

Merged
merged 1 commit into from
Feb 15, 2024

Conversation

ArtBlue
Copy link
Contributor

@ArtBlue ArtBlue commented Feb 13, 2024

Fixes #2265

  • This PR contains CSS changes
  • This PR does not contain CSS changes

Description

The border was missing from the original icon. I added stroke-width="1" (there for other icons with borders) to the original icons and regenerated the icons.

Screenshots

Before
image

After
image

Checklist

  • I verify the build is in a non-broken state
  • I verify all changes are within scope of the linked issue
  • I regenerated all CSS files under dist folder
  • I tested the UI in all supported browsers
  • I did a visual regression check of the components impacted by doing a Percy build and approved the build
  • I tested the UI in dark mode and RTL mode
  • I added/updated/removed Storybook coverage as appropriate

@ArtBlue ArtBlue merged commit 92b933b into 17.2.0 Feb 15, 2024
2 checks passed
@ArtBlue ArtBlue deleted the 2265-venmo-icon-missing-borders branch February 15, 2024 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants