Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

education-notice: : use icon button #2293

Closed
6 tasks done
ArtBlue opened this issue Mar 18, 2024 · 0 comments
Closed
6 tasks done

education-notice: : use icon button #2293

ArtBlue opened this issue Mar 18, 2024 · 0 comments
Assignees
@ArtBlue
Labels
type: feature
Milestone
17.3.0

Comments

@ArtBlue
Copy link
Contributor

ArtBlue commented Mar 18, 2024 •
edited
Loading

Description

Change prompted by DS...

For the new education-notice, use an icon button, instead of the current button.

Engineering pre-requisites

  • Successful design review with Design System Team.
  • Supports dark mode.
  • Supports responsive design.
  • Tokens have been provided (or already exist).
  • Successful accessibility review with Core A11Y Team.
  • Successful frontend review with eBayUI Team.
@ArtBlue ArtBlue added this to the 17.3.0 milestone Mar 18, 2024
@ArtBlue ArtBlue self-assigned this Mar 18, 2024
@ArtBlue ArtBlue added this to eBayUI Mar 18, 2024
@ArtBlue ArtBlue moved this to In Progress in eBayUI Mar 18, 2024
@ArtBlue ArtBlue mentioned this issue Mar 18, 2024
Merged
9 tasks
@agliga agliga moved this from In Progress to Pull request in eBayUI Mar 18, 2024
@ArtBlue ArtBlue moved this from Pull request to Done in eBayUI Mar 19, 2024
@ArtBlue ArtBlue closed this as completed Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ArtBlue ArtBlue

Labels
type: feature
Projects
eBayUI
Status: Done
Milestone
17.3.0
Development

When branches are created from issues, their pull requests are automatically linked.

2293-education-notice-use-icon-button eBay/skin
1 participant
@ArtBlue