Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

progress-bar-expressive: expressive progress bar reading aloud too much in docs #2311

Closed
1 task done
cordeliadillon opened this issue Apr 12, 2024 · 0 comments · Fixed by #2312
Closed
1 task done
Assignees
Milestone

Comments

@cordeliadillon
Copy link
Contributor

I verified there's no existing issue for this bug.

  • There are no existing issues

Current behavior

The expressive progress bar module features an ARIA live region (role="status") that announces rotating messages to screen readers.

All Skin component docs are compiled into a single HTML page, so the expressive progress bar docs and examples are rendered any time you visit the Skin docs. This means that when perusing the docs with a screen reader, you always hear the expressive progress bar messages. This can be distracting, especially when exploring other components' docs.

Expected behavior

In the docs, the expressive progress bar code examples should include role=status markup, but the actual rendered examples should not.

Skin version

No response

Device/OS/Browser info

No response

Steps to reproduce

1. Turn on a screen reader.
2. Navigate to https://opensource.ebay.com/skin/
3. Be reminded every second and a half that your order is almost ready.

Relevant code block

No response

Additional context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant