Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tsv-split named field support #291

Merged
merged 1 commit into from
Jun 14, 2020

Conversation

jondegenhardt
Copy link
Contributor

This PR is a follow-on to PRs #284, #285, #286, #288, and #289. It adds named field support to tsv-uniq. It works the same way as the support added to tsv-select, see PR #284 for more info.

Named field support is backward compatible with numeric fields. As with the other tools, this support is not documented yet, even in the help text. Documentation will be added when named field support has been added to all tools and a release performed.

This PR also fixes a regression introduced in PR #290. That PR incorrectly identified field groups containing a backslash escaped hyphen as a mixed named-numeric ranges. These were flagged as invalid, incorrectly terminating command line argument processing.

This is a step towards enhancement request #25.

@codecov-commenter
Copy link

Codecov Report

Merging #291 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #291   +/-   ##
=======================================
  Coverage   99.33%   99.33%           
=======================================
  Files          18       18           
  Lines        6607     6657   +50     
=======================================
+ Hits         6563     6613   +50     
  Misses         44       44           
Impacted Files Coverage Δ
common/src/tsv_utils/common/fieldlist.d 99.88% <100.00%> (+<0.01%) ⬆️
tsv-split/src/tsv_utils/tsv-split.d 98.48% <100.00%> (+0.03%) ⬆️

@jondegenhardt jondegenhardt merged commit 36aabb3 into eBay:master Jun 14, 2020
@jondegenhardt jondegenhardt deleted the fieldlist-tsv-split branch June 14, 2020 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants