Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20413] Fix doxygen docs warnings. Prepare for compiling with Doxygen 1.10.0 #194

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

Mario-DL
Copy link
Member

The actual utils/doxygen/doxygenfiles/mainpage.dox that defines the main doxygen groups is not being loaded (see here), so, when compiling with recent versions of doxygen (>= 1.10.0) the @ingroup macros complain that the doxygen FASTCDRAPIREFERENCE and EXCEPTIONMODULE groups are not defined.

This PR adds a doxygen_modules.h header under config that declares the groups and solve the compilation warning with recent versions.

A final consideration:

This PR does NOT upgrade the doxyfile.in to 1.10.0 yet, so building with doxygen 1.10.0 and -DBUILD_DOCUMENTATION=ON still outputs a bunch of info messages complaining that some of the configuration options are obsolete, but now, the compilation finishes successfully.

This PR is congruent with eProsima/Fast-DDS#4376.

Fixes #193

@Mario-DL Mario-DL force-pushed the fix/doxygen-warnings branch 2 times, most recently from 83e37f5 to 023231c Compare February 12, 2024 14:06
@richiprosima
Copy link
Contributor

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status

Copy link
Contributor

@JesusPoderoso JesusPoderoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EduPonz EduPonz added this to the v2.2.0 milestone Feb 15, 2024
@JesusPoderoso
Copy link
Contributor

Manual run launched here

@JesusPoderoso
Copy link
Contributor

@Mergifyio rebase

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Copy link

mergify bot commented Feb 21, 2024

rebase

✅ Branch has been successfully rebased

@richiprosima
Copy link
Contributor

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status

@JesusPoderoso JesusPoderoso merged commit fe726a8 into master Feb 21, 2024
16 checks passed
@JesusPoderoso JesusPoderoso deleted the fix/doxygen-warnings branch February 21, 2024 12:46
EduPonz pushed a commit that referenced this pull request Feb 22, 2024
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API doc generation fails with doxygen 1.10.0
4 participants