Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refs 15766: update shared_mutex docs #413

Merged
merged 3 commits into from
Nov 14, 2022

Conversation

MiguelBarro
Copy link
Contributor

Documentation update associated with: eProsima/Fast-DDS#2976

@MiguelBarro
Copy link
Contributor Author

@richiprosima Please I have rebased my Fast-DDS branch to fix docs CI, test docs for me 😅

@MiguelBarro MiguelBarro force-pushed the feature/shared_mutex/writer_priority branch from 51aaa45 to 2606160 Compare October 3, 2022 13:04
JLBuenoLopez
JLBuenoLopez previously approved these changes Nov 10, 2022
Copy link
Contributor

@JLBuenoLopez JLBuenoLopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM though there is a small nitpick.

docs/installation/configuration/cmake_options.rst Outdated Show resolved Hide resolved
JLBuenoLopez
JLBuenoLopez previously approved these changes Nov 10, 2022
Copy link
Contributor

@JLBuenoLopez JLBuenoLopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@MiguelCompany
Copy link
Member

@MiguelBarro This one has conflicts ....

Miguel Barro added 2 commits November 11, 2022 11:42
Signed-off-by: Miguel Barro <miguelbarro@eprosima.com>
Signed-off-by: Miguel Barro <miguelbarro@eprosima.com>
@MiguelBarro MiguelBarro force-pushed the feature/shared_mutex/writer_priority branch 2 times, most recently from 412abbb to da8af4f Compare November 11, 2022 12:13
Signed-off-by: Miguel Barro <miguelbarro@eprosima.com>
@MiguelBarro MiguelBarro force-pushed the feature/shared_mutex/writer_priority branch from da8af4f to e1657b3 Compare November 14, 2022 09:49
Copy link
Contributor

@JLBuenoLopez JLBuenoLopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MiguelCompany MiguelCompany merged commit f56f5ed into master Nov 14, 2022
@MiguelCompany MiguelCompany deleted the feature/shared_mutex/writer_priority branch November 14, 2022 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants