Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[21054] Make explicit the need to keep alive the flow controller descriptor name #806

Merged
merged 3 commits into from
Jun 8, 2024

Conversation

Mario-DL
Copy link
Member

@Mario-DL Mario-DL commented Jun 7, 2024

Description

#793 Introduced an ABI break changing const char* to std:.string in the flow controller descriptor name. This PR warns the user in the sample snippets that the name must be kept alive during participants lifetime.

Important This PR has to be cherry picked on the following backports:

Contributor Checklist

  • Commit messages follow the project guidelines.
  • Code snippets related to the added documentation have been provided.
  • Documentation tests pass locally.
  • NO (see PR description) Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • CI passes without warnings or errors.

…ow controller descriptor name

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
code/DDSCodeTester.cpp Outdated Show resolved Hide resolved
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
@JesusPoderoso
Copy link
Contributor

@richiprosima please test this

code/DDSCodeTester.cpp Outdated Show resolved Hide resolved
code/DDSCodeTester.cpp Outdated Show resolved Hide resolved
@EduPonz EduPonz merged commit d53fab7 into 2.14.x Jun 8, 2024
2 of 3 checks passed
@EduPonz EduPonz deleted the bugfix/2.x/21054 branch June 8, 2024 05:50
@EduPonz
Copy link

EduPonz commented Jun 8, 2024

@Mario-DL please remember to cherry-pick this onto the other backports

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants