Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[21745] Add tests for new QoS getters from raw XML #189

Merged
merged 3 commits into from
Oct 14, 2024

Conversation

juanlofer-eprosima
Copy link
Contributor

@juanlofer-eprosima juanlofer-eprosima commented Oct 14, 2024

Description

Add tests for new API introduced in eProsima/Fast-DDS#5256

Contributor Checklist

  • Commit messages follow the project guidelines.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Changes are API compatible.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

Signed-off-by: Juan Lopez Fernandez <juanlopez@eprosima.com>
Signed-off-by: Juan Lopez Fernandez <juanlopez@eprosima.com>
@github-actions github-actions bot added the ci-pending PR which CI is running label Oct 14, 2024
@JesusPoderoso JesusPoderoso added this to the v2.1.0 milestone Oct 14, 2024
JesusPoderoso

This comment was marked as resolved.

JesusPoderoso

This comment was marked as resolved.

@juanlofer-eprosima
Copy link
Contributor Author

I am missing also tests to check that the QoS returned differ if the name provided is not default, as well as if the first profile found is not the named one.

I believe these tests are meant to simply check the python API is working well, more exhaustive tests covering all cases would probably be better in the C++ repository.

Signed-off-by: Juan Lopez Fernandez <juanlopez@eprosima.com>
@juanlofer-eprosima juanlofer-eprosima requested review from JesusPoderoso and removed request for richiware October 14, 2024 14:18
@JesusPoderoso JesusPoderoso merged commit e89a029 into main Oct 14, 2024
6 checks passed
@JesusPoderoso JesusPoderoso deleted the feature/get-qos-from-xml branch October 14, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-pending PR which CI is running
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants