Refs #20849: Apply suggestions

Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
eProsima · May 17, 2024 · 43623c5 · 43623c5
1 parent 5967809
commit 43623c5
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 13 deletions.
diff --git a/test/blackbox/api/dds-pim/PubSubWriter.hpp b/test/blackbox/api/dds-pim/PubSubWriter.hpp
@@ -280,11 +280,10 @@ class PubSubWriter
     typedef typename type_support::type type;
 
     PubSubWriter(
-            const std::string& topic_name,
-            eprosima::fastdds::dds::DomainParticipant* participant = nullptr)
+            const std::string& topic_name)
         : participant_listener_(*this)
         , listener_(*this)
-        , participant_(participant)
+        , participant_(nullptr)
         , topic_(nullptr)
         , publisher_(nullptr)
         , datawriter_(nullptr)

diff --git a/test/blackbox/common/DDSBlackboxTestsBasic.cpp b/test/blackbox/common/DDSBlackboxTestsBasic.cpp
@@ -780,12 +780,10 @@ TEST(DDSBasic, max_output_message_size_participant)
             };
 
     // Create the DomainParticipants with the appropriate value for the property
-    DomainParticipantQos participant_qos;
-    participant_qos.properties().properties().emplace_back("fastdds.max_message_size", segment_size_str);
-    DomainParticipant* participant =
-            DomainParticipantFactory::get_instance()->create_participant((uint32_t)GET_PID() % 230, participant_qos);
-    PubSubWriter<Data1mbPubSubType> writer(TEST_TOPIC_NAME, participant);
-    writer.disable_builtin_transport()
+    eprosima::fastrtps::rtps::PropertyPolicy property_policy;
+    property_policy.properties().emplace_back("fastdds.max_message_size", segment_size_str);
+    PubSubWriter<Data1mbPubSubType> writer(TEST_TOPIC_NAME);
+    writer.property_policy(property_policy).disable_builtin_transport()
             .add_user_transport_to_pparams(testTransport).init();
     EXPECT_TRUE(writer.isInitialized());
 
@@ -804,8 +802,6 @@ TEST(DDSBasic, max_output_message_size_participant)
     // Wait for reception
     reader.block_for_all(std::chrono::seconds(1));
     EXPECT_EQ(reader.getReceivedCount(), 1u);
-
-    DomainParticipantFactory::get_instance()->delete_participant(participant);
 }
 
 /**
@@ -828,8 +824,8 @@ TEST(DDSBasic, max_output_message_size_writer)
     eprosima::fastrtps::rtps::PropertyPolicy property_policy;
     property_policy.properties().emplace_back("fastdds.max_message_size", segment_size_str);
     PubSubWriter<Data1mbPubSubType> writer(TEST_TOPIC_NAME);
-    writer.property_policy(property_policy).disable_builtin_transport().add_user_transport_to_pparams(testTransport);
-    writer.init();
+    writer.entity_property_policy(property_policy).disable_builtin_transport()
+            .add_user_transport_to_pparams(testTransport).init();
     ASSERT_TRUE(writer.isInitialized());
 
     PubSubReader<Data1mbPubSubType> reader(TEST_TOPIC_NAME);