Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing test: TimedEventTests #23

Closed
gerkey opened this issue Mar 3, 2016 · 8 comments
Closed

Failing test: TimedEventTests #23

gerkey opened this issue Mar 3, 2016 · 8 comments

Comments

@gerkey
Copy link
Contributor

gerkey commented Mar 3, 2016

This build:

http://ci.ros2.org/view/nightly/job/nightly_osx/234/testReport/projectroot.test.unittest.rtps.resources/timedevent/TimedEventTests/

shows a test failure on OSX for TimedEventTests. The tail end of the console output is:

[ RUN      ] TimedEvent.EventNonAutoDestruct_AutoRestart
[       OK ] TimedEvent.EventNonAutoDestruct_AutoRestart (10521 ms)
[ RUN      ] TimedEvent.EventNonAutoDestruc_AutoRestartAndDeleteRandomly
libc++abi.dylib: Pure virtual function called!

Looks like the program is crashing. Let us know if you need help reproducing it.

@richiprosima
Copy link
Contributor

We fixed an invalid read detected by valgrind in the tests that may be related with your failure. We don't use OSX and never had that failture. Can you check it again with commit ca6d226? Thanks

@gerkey
Copy link
Contributor Author

gerkey commented Mar 8, 2016

richiprosima added a commit that referenced this issue Mar 8, 2016
Updated performance tests.
@richiprosima
Copy link
Contributor

I found an error in test TimedEventTests. And yes, it's was a random error.

@gerkey
Copy link
Contributor Author

gerkey commented Mar 8, 2016

That fix looks very promising, thanks. I'll report back after we've had a couple of days of nightly test runs.

@gerkey
Copy link
Contributor Author

gerkey commented Mar 9, 2016

It looks like the problem is fixed for Release and "none" build types, which is great!

Now we have a different failure from OSX built in Debug: http://ci.ros2.org/view/nightly/job/nightly_osx_debug/6/testReport/projectroot.test.unittest.rtps.resources/timedevent/TimedEventTests/. The error:

[ RUN      ] TimedEvent.EventNonAutoDestruc_AutoRestartAndDeleteRandomly
Assertion failed: (!res), function ~mutex, file /usr/local/include/boost/thread/pthread/mutex.hpp, line 111.
Assertion failed: (!pthread_mutex_lock(m)), function pthread_mutex_scoped_lock, file /usr/local/include/boost/thread/pthread/pthread_mutex_scoped_lock.hpp, line 26.

@richiprosima
Copy link
Contributor

I've seen that and i'm working on it.

richiprosima added a commit that referenced this issue Mar 10, 2016
@richiprosima
Copy link
Contributor

Solved last issue in TimedEventTests.

@gerkey
Copy link
Contributor Author

gerkey commented Mar 15, 2016

Indeed, that failure didn't occur in any of our builds from last night. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants