Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes and improvements on StatefulWriter <2.0.x> [8324] #1190

Merged
merged 14 commits into from
May 4, 2020
Merged

Fixes and improvements on StatefulWriter <2.0.x> [8324] #1190

merged 14 commits into from
May 4, 2020

Conversation

MiguelCompany
Copy link
Member

@MiguelCompany MiguelCompany commented Apr 30, 2020 •
edited
Loading

This PR:

  • Adds generic filtering mechanisms to the test_udpv4 transport
  • Improves sending gaps for holes in history
  • Fixes locator selection when re-sending samples to specific readers
  • Fixes late-joining reliable volatile readers never notifying samples on some cases

@richiware
Copy link
Member

richiware commented Apr 30, 2020 •
edited by MiguelCompany
Loading

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status

Unrelated failures

@MiguelCompany MiguelCompany added this to the v2.0 milestone Apr 30, 2020
@MiguelCompany MiguelCompany changed the title Fixes and improvements on StatefulWriter <2.0.x> Fixes and improvements on StatefulWriter <2.0.x> [8324] Apr 30, 2020
MiguelCompany and others added 13 commits April 30, 2020 11:40
@MiguelCompany
Refs #7920. Improving send_all_unsent_changes.
bf850fb 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Refs #7920. Added Blackbox test for transient_local writer and volati…
b8f6c45 
…le reader.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Refs #7920. Fixing handling of volatile on ReaderProxy.
a1c35b5 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Refs #7920. Fixing heartbeat before gaps to intraprocess readers.
27f3085 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@IkerLuengo @MiguelCompany
Refs #8296 custom filters for msg dropping on test_UDPv4
6a2bca8 
Signed-off-by: Iker Luengo <ikerluengo@eprosima.com>
@IkerLuengo @MiguelCompany
Refs #8296 Blackbox for missing GAP on late joiner volatile subscriber
ac72fd2 
Signed-off-by: Iker Luengo <ikerluengo@eprosima.com>
@IkerLuengo @MiguelCompany
Refs #8296 Writer to wait for specific amount of discoveries
313efbd 
Signed-off-by: Iker Luengo <ikerluengo@eprosima.com>
@MiguelCompany
Refs #7920. Added test VolatileSubBetweenPubs.
7686c42 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Refs #7920. Sending intraprocess heartbeat on sync write.
5565b71 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Refs #7920. Improving initial gaps on intraprocess heartbeat.
39720e4 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Refs #7920. Fix on intraprocess_heartbeat.
1f431ff 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Refs #7920. Sending initial gap along with heartbeat for volatile.
30f8f6f 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@IkerLuengo @MiguelCompany
Refs #7920. Added test VolatileSubBetweenTransientPubs
ee45114 
Signed-off-by: Iker Luengo <ikerluengo@eprosima.com>
@richiware
Copy link
Member

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status

EduPonz
EduPonz previously approved these changes Apr 30, 2020
View reviewed changes
Copy link

@EduPonz EduPonz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor changes

test/blackbox/BlackboxTestsVolatile.cpp Show resolved Hide resolved
test/blackbox/BlackboxTestsVolatile.cpp Outdated Show resolved Hide resolved
test/blackbox/BlackboxTestsVolatile.cpp Show resolved Hide resolved
test/blackbox/BlackboxTestsVolatile.cpp Show resolved Hide resolved
test/blackbox/BlackboxTestsVolatile.cpp Outdated Show resolved Hide resolved
test/blackbox/BlackboxTestsVolatile.cpp Show resolved Hide resolved
test/blackbox/BlackboxTestsVolatile.cpp Show resolved Hide resolved
test/blackbox/BlackboxTestsVolatile.cpp Show resolved Hide resolved
@MiguelCompany
Refs #8324. Suggested changes.
c4fc590 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
EduPonz
EduPonz approved these changes Apr 30, 2020
View reviewed changes
Copy link

@EduPonz EduPonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@richiware
Copy link
Member

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status

@MiguelCompany MiguelCompany merged commit a9bd1a9 into 2.0.x May 4, 2020
@MiguelCompany MiguelCompany deleted the bugfix/stateful-writer/2.0.x branch May 4, 2020 06:32
This was referenced May 4, 2020
Closed
Closed
@MiguelCompany MiguelCompany mentioned this pull request Jul 8, 2020
Open
@MiguelCompany MiguelCompany mentioned this pull request Jul 14, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EduPonz EduPonz EduPonz approved these changes

@richiware richiware Awaiting requested review from richiware

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.0
Development

Successfully merging this pull request may close these issues.
4 participants
@MiguelCompany @richiware @EduPonz @IkerLuengo