Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes and improvements on StatefulWriter <2.0.x> [8324] #1190

Merged
merged 14 commits into from
May 4, 2020

Conversation

MiguelCompany
Copy link
Member

@MiguelCompany MiguelCompany commented Apr 30, 2020

This PR:

  • Adds generic filtering mechanisms to the test_udpv4 transport
  • Improves sending gaps for holes in history
  • Fixes locator selection when re-sending samples to specific readers
  • Fixes late-joining reliable volatile readers never notifying samples on some cases

@richiware
Copy link
Member

richiware commented Apr 30, 2020

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status

Unrelated failures

@MiguelCompany MiguelCompany added this to the v2.0 milestone Apr 30, 2020
@MiguelCompany MiguelCompany changed the title Fixes and improvements on StatefulWriter <2.0.x> Fixes and improvements on StatefulWriter <2.0.x> [8324] Apr 30, 2020
MiguelCompany and others added 13 commits April 30, 2020 11:40
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
…le reader.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Iker Luengo <ikerluengo@eprosima.com>
Signed-off-by: Iker Luengo <ikerluengo@eprosima.com>
Signed-off-by: Iker Luengo <ikerluengo@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Iker Luengo <ikerluengo@eprosima.com>
@richiware
Copy link
Member

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status

EduPonz
EduPonz previously approved these changes Apr 30, 2020
Copy link

@EduPonz EduPonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor changes

test/blackbox/BlackboxTestsVolatile.cpp Show resolved Hide resolved
test/blackbox/BlackboxTestsVolatile.cpp Outdated Show resolved Hide resolved
test/blackbox/BlackboxTestsVolatile.cpp Show resolved Hide resolved
test/blackbox/BlackboxTestsVolatile.cpp Show resolved Hide resolved
test/blackbox/BlackboxTestsVolatile.cpp Outdated Show resolved Hide resolved
test/blackbox/BlackboxTestsVolatile.cpp Show resolved Hide resolved
test/blackbox/BlackboxTestsVolatile.cpp Show resolved Hide resolved
test/blackbox/BlackboxTestsVolatile.cpp Show resolved Hide resolved
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Copy link

@EduPonz EduPonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@richiware
Copy link
Member

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants