-
Notifications
You must be signed in to change notification settings - Fork 787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementation of unique locators request feature for readers [10497] #1768
Merged
MiguelCompany
merged 8 commits into
feature/unique_network_flows
from
feature/unique-locators-request-readers
Feb 19, 2021
Merged
Implementation of unique locators request feature for readers [10497] #1768
MiguelCompany
merged 8 commits into
feature/unique_network_flows
from
feature/unique-locators-request-readers
Feb 19, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
MiguelCompany
force-pushed
the
feature/unique-locators-request-readers
branch
from
February 18, 2021 14:12
cf8ba15
to
55bfc82
Compare
IkerLuengo
approved these changes
Feb 18, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
MiguelCompany
added a commit
that referenced
this pull request
Feb 26, 2021
* Refs 10497. Update sub_unique_network_flows blackbox. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 10497. Added PubSubBasic test with unique flows feature. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 10497. Added method to parse property value. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 10497. createReceiverResources now returns bool. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 10497. Try to create specific resources when requested. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 10497. PubSubParticipant takes data when received. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 10497. Uncrustify. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 10497. Fix build error on non-windows platforms. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
EduPonz
pushed a commit
that referenced
this pull request
Mar 1, 2021
* Extend endpoint QoS with new unique locators request feature (#1757) * Refs 10496. Prepare compatibility checks on DataReaderQos. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 10496. Remove old TODO code. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * fixup * Refs 10496. Add InvalidQos checks to DataReaderTests. * Refs 10496. Fix link error on ListenerTests. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 10496. Fixed const -> const ref on property policy setters. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 10496. Add blackbox test expecting endpoint creation failure. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 10496. Fail on creation of endpoints requesting unique_network_flows. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 10496. Add check for UNSUPPORTED_QOS on DataWriterTests. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 10496.Fail with unsupported on DataWriterImpl::check_qos. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Extend endpoint APIs with getters for currently used locators (#1749) * Refs 10495. Modified Subscriber API to retrieve endpoint listening locators Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 10495. Removed unnecessary RTPS_DllAPI. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 10495. Added get_listening_locators to DataReader API. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 10495. Added test to DataReaderTests. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 10495. Blackbox test added. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 10495. Uncrustify SenderResource headers. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 10495. Add empty interface add_locators_to_list. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 10495. Implementation of UDPSenderResource::add_locators_to_list. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 10495. Method endpoint_to_locator sets locator kind. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 10495. Added RTPSParticipantImpl::get_sending_locators. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 10495. Added get_sending_locators to fastrtps Publisher. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 10495. Added get_sending_locators to fastdds DataWriter. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 10495. Blackbox test added. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 10495. Fixing mock of RTPSParticipantImpl. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 10495. Extended test on DataReader. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 10495. Added PubGetSendingLocatorsWhitelist blackbox test. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 10495. Remove unused forward declarations Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 10495. Fixed build error on Linux and Mac. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 10495. Fixed typo on DataReaderTests. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 10495. Uncrustify. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 10495. Moving LocatorList_t to eprosima::fastdds::rtps. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 10495. Using LocatorList from new namespace on DataWriter. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 10495. Using LocatorList from new namespace on DataReader. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 10495. Updating includes on core/policy. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 10495. Include what you use on NetworkFactory.h. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 10495. Updating transports. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 10495. Updating discovery server code. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 10495. Updating utils::Host. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 10495. Updating tests. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 10495. Updating examples. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 10495. Uncrustify. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 10495. Adding debug to Blackbox test. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Fix on blackbox test Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Implementation of unique locators request feature for readers (#1768) * Refs 10497. Update sub_unique_network_flows blackbox. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 10497. Added PubSubBasic test with unique flows feature. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 10497. Added method to parse property value. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 10497. createReceiverResources now returns bool. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 10497. Try to create specific resources when requested. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 10497. PubSubParticipant takes data when received. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 10497. Uncrustify. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 10497. Fix build error on non-windows platforms. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the request for unique network flows on the readers.
Depends on #1749