Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14101] Upgrading CMake c++ standard management #2579

Merged
merged 13 commits into from
Jun 30, 2022
Merged

[14101] Upgrading CMake c++ standard management #2579

merged 13 commits into from
Jun 30, 2022

Conversation

MiguelBarro
Copy link
Contributor

@MiguelBarro MiguelBarro commented Mar 15, 2022 •
edited
Loading

Description

This pull request deprecates #2084 that partially approach the subject missing:

  • CMake detection of the supported standards.
  • Backwards compatibility

All preprocessor workarounds to address non C++11 availability have been removed too.
FindAtomic module has been updated too to avoid deprecated CMake features.

Tests have been added for the updated CMake module.

This pull request must be merged after #2583 because the module update requires features available in CMake 3.16.

Relates to eProsima/Fast-CDR#122

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A CMake Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added.
  • N/A CMake Any new/modified methods have been properly documented using Doxygen.
  • Fast DDS test suite has been run locally. In raspbian too 😎
  • Changes are ABI compatible.
  • Changes are API compatible.
  • Documentation builds and tests pass locally.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.

Reviewer Checklist

  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@MiguelBarro MiguelBarro self-assigned this Mar 15, 2022
This was referenced Mar 15, 2022
Closed
Merged
@MiguelBarro MiguelBarro force-pushed the feature/cxx_force branch 4 times, most recently from 9f81c81 to 8dd1bab Compare March 16, 2022 08:11
@MiguelBarro
Copy link
Contributor Author

@richiprosima Please be so gentle to test Windows for me 😎

@MiguelBarro MiguelBarro force-pushed the feature/cxx_force branch 2 times, most recently from 8820ee1 to 570b09f Compare March 17, 2022 21:43
@MiguelCompany MiguelCompany added this to the v2.7.0 milestone Apr 11, 2022
jsan-rt
jsan-rt suggested changes Apr 11, 2022
View reviewed changes
Copy link
Contributor

@jsan-rt jsan-rt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the, in my opinion, superfluous parameter most of the comments are just some nitpicks regarding inconsistent capitalization in comments. I've just outlined a few.

cmake/common/check_configuration.cmake Outdated Show resolved Hide resolved
cmake/common/check_configuration.cmake Show resolved Hide resolved
cmake/common/check_configuration.cmake Show resolved Hide resolved
cmake/modules/FindAtomic.cmake Outdated Show resolved Hide resolved
cmake/common/check_configuration.cmake Outdated Show resolved Hide resolved
cmake/common/check_configuration.cmake Outdated Show resolved Hide resolved
cmake/common/check_configuration.cmake Outdated Show resolved Hide resolved
cmake/common/check_configuration.cmake Outdated Show resolved Hide resolved
cmake/common/check_configuration.cmake Outdated Show resolved Hide resolved
cmake/modules/FindAtomic.cmake Outdated Show resolved Hide resolved
Miguel Barro added 12 commits June 29, 2022 12:43
Refs 14101. Upgrade our standard selection method
2291368 
Signed-off-by: Miguel Barro <miguelbarro@eprosima.com>
Refs 1401. Change the approach to support complete backward compatibi…
d5746e0 
…lity.

Signed-off-by: Miguel Barro <miguelbarro@eprosima.com>
Refs 14101. Full support for constexpr
fd4f1cb 
Signed-off-by: Miguel Barro <miguelbarro@eprosima.com>
Refs 14101. Deprecate TestBigEndian as adviced by CMake
9bca5dd 
Signed-off-by: Miguel Barro <miguelbarro@eprosima.com>
Refs 14101. enabling C compiler in sqlite tests
99c7851 
Signed-off-by: Miguel Barro <miguelbarro@eprosima.com>
Refs 14101. fixing c++11 flag mistype
9f24215 
Signed-off-by: Miguel Barro <miguelbarro@eprosima.com>
Refs 14101. Setting global variables instead of local ones
54a177a 
Signed-off-by: Miguel Barro <miguelbarro@eprosima.com>
Refs 14101. Fixes on fallback mechanism
74f6d9d 
Signed-off-by: Miguel Barro <miguelbarro@eprosima.com>
Refs 14101. Test CXX_FORCE variable.
030267d 
Signed-off-by: Miguel Barro <miguelbarro@eprosima.com>
Refs 14101. Avoid setting CMAKE_CXX_STANDARD as cache variable.
fe91150 
Signed-off-by: Miguel Barro <miguelbarro@eprosima.com>
Refs 14101. Avoid deprecated cmake compiler id vars
412e22c 
Signed-off-by: Miguel Barro <miguelbarro@eprosima.com>
Refs 14101. Addressing reviewers comments
92cd6dd 
Signed-off-by: Miguel Barro <miguelbarro@eprosima.com>
@jsan-rt
Copy link
Contributor

jsan-rt commented Jun 29, 2022

@richiprosima please test this again

jsan-rt
jsan-rt previously approved these changes Jun 29, 2022
View reviewed changes
@jsan-rt jsan-rt self-requested a review June 29, 2022 20:06
@jsan-rt jsan-rt dismissed their stale review June 29, 2022 20:06

Mac CI failing. Needs further testing.

@MiguelCompany MiguelCompany added the no-test Skip CI tests if PR marked with this label label Jun 30, 2022
Refs 14101. Amend error on previous commit
ef4f640 
Signed-off-by: Miguel Barro <miguelbarro@eprosima.com>
@MiguelBarro
Copy link
Contributor Author

@richiprosima please test Mac. Let's see what happens with the examples CMake.

@MiguelBarro
Copy link
Contributor Author

The examples issue is fixed

@MiguelCompany
Copy link
Member

@richiprosima Please test this to check it builds in all platforms.

@MiguelCompany MiguelCompany merged commit ec6c895 into master Jun 30, 2022
@MiguelCompany MiguelCompany deleted the feature/cxx_force branch June 30, 2022 14:41
@wep21 wep21 mentioned this pull request Jun 30, 2022
Merged
@Mario-DL Mario-DL mentioned this pull request Jun 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsan-rt jsan-rt Awaiting requested review from jsan-rt

Assignees

@MiguelBarro MiguelBarro

Labels
no-test Skip CI tests if PR marked with this label
Projects
None yet
Milestone
v2.7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@MiguelBarro @jsan-rt @MiguelCompany