Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/dynamic types #276

Merged
merged 226 commits into from
Oct 22, 2018
Merged

Feature/dynamic types #276

merged 226 commits into from
Oct 22, 2018

Conversation

LuisGP
Copy link
Contributor

@LuisGP LuisGP commented Oct 15, 2018 •
edited
Loading

  • Added support for dynamic types 1.1 (minimals checking)
  • Added TypeObject and TypeIdentifier generation
  • Conversion functions between dynamic types and TypeObject/TypeIdentifier

@LuisGP LuisGP requested a review from richiware October 15, 2018 06:47
richiware
richiware previously approved these changes Oct 15, 2018
View reviewed changes
.gitmodules Outdated Show resolved Hide resolved
fastrtpsgen/.settings/org.eclipse.buildship.core.prefs Outdated Show resolved Hide resolved
examples/C++/DynamicHelloWorldExample/HelloWorldPublisher.cpp Outdated Show resolved Hide resolved
examples/C++/DynamicHelloWorldExample/HelloWorldPublisher.cpp Outdated Show resolved Hide resolved
examples/C++/DynamicHelloWorldExample/HelloWorldPublisher.cpp Outdated Show resolved Hide resolved
examples/C++/DynamicHelloWorldExample/HelloWorldSubscriber.cpp Outdated Show resolved Hide resolved
examples/C++/DynamicHelloWorldExample/HelloWorldSubscriber.cpp Outdated Show resolved Hide resolved
examples/C++/DynamicHelloWorldExample/HelloWorldSubscriber.cpp Outdated Show resolved Hide resolved
fastrtpsgen/src/com/eprosima/fastrtps/idl/templates/CMakeLists.stg Outdated Show resolved Hide resolved
include/fastrtps/Domain.h Outdated Show resolved Hide resolved
@LuisGP LuisGP force-pushed the feature/dynamic-types branch 2 times, most recently from 40a2b90 to e07efec Compare October 16, 2018 10:27
richiware
richiware requested changes Oct 17, 2018
View reviewed changes
include/fastrtps/Domain.h Outdated Show resolved Hide resolved
@LuisGP LuisGP force-pushed the feature/dynamic-types branch from e07efec to 88726f1 Compare October 17, 2018 10:55
@richiware richiware assigned LuisGP and unassigned richiware Oct 17, 2018
@LuisGP LuisGP assigned richiware and unassigned LuisGP Oct 17, 2018
richiware
richiware requested changes Oct 17, 2018
View reviewed changes
Copy link
Member

@richiware richiware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DynamicHelloWorldExamples doesn't communicate with HelloWorldExample. This should be fixed.

@LuisGP
Copy link
Contributor Author

LuisGP commented Oct 17, 2018

DynamicHelloWorld was publishing at domain 5 instead 0 and probably, the minimal type checking wasn't helping neither.

richiware
richiware requested changes Oct 18, 2018
View reviewed changes
Copy link
Member

@richiware richiware left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI job informs about memory leak in dynamic tests.

http://ci.intranet.eprosima.com:8080/job/FastRTPS%20Manual%20Linux/833

Juan Carlos Arceredillo and others added 12 commits October 19, 2018 08:26
Refs #3079. Initial structure of classes for the dynamic objects.
22b7766 
# Conflicts:
#	src/cpp/CMakeLists.txt

# Conflicts:
#	src/cpp/CMakeLists.txt
Refs #3079 Move some classes to another header file.
1d4cf5b
Refs #3079. Update AnnotationDescriptor and MemberDescriptor classes.
b6d5786
Refs #3079 Update the Dynamic Types Management.
b222abf
Refs #3079 Rename file DynamicTypeBuilderFactory
57d5fc5
Refs #3079 Rename file DynamicTypeBuilderFactory
3457b35
Refs #3079. Manage the memory on every class of dynamic types
e134968
Refs #3078 TypeObject and inner classes.
c405b3e
Refs #3079 Implement several method to modify the attributes of the D…
0b1a9ac 
…ynamic Data
Merge branch 'dynamicTypes' of https://192.168.1.4/LuisGasco/fastrtps …
7aefe01 
…into dynamicTypes
Refs #3078 Compilation errors solved.
f071344
Refs #3079 Fix compilation errors on Windows.
22fa6ec
Luis Gasco and others added 20 commits October 19, 2018 08:33
Refs #3276 Unitialized key buffer.
28ca670
Refs #3287 Added mechanism to remove profiles from XMLProfileManager …
fe06c98 
…between tests executions.

# Conflicts:
#	include/fastrtps/xmlparser/XMLProfileManager.h

# Conflicts:
#	include/fastrtps/xmlparser/XMLProfileManager.h
Refs #3289 Added dynamic type generation by XML
de4632d 
# Conflicts:
#	include/fastrtps/xmlparser/XMLParser.h
#	include/fastrtps/xmlparser/XMLProfileManager.h
#	resources/xsd/fastRTPS_profiles.xsd
#	src/cpp/xmlparser/XMLParser.cpp
#	src/cpp/xmlparser/XMLProfileManager.cpp

# Conflicts:
#	include/fastrtps/xmlparser/XMLParser.h
#	include/fastrtps/xmlparser/XMLProfileManager.h
#	src/cpp/xmlparser/XMLParser.cpp
#	src/cpp/xmlparser/XMLProfileManager.cpp
Refs #3289 Added enum, typdef, map, and inner types as nodes instead …
70ff6c0 
…attributes (optional) to allow complex types to dynamic type generation by XML.
Refs #3387 Dynamic Types in its own branch
2ae041c 
# Conflicts:
#	test/unittest/transport/CMakeLists.txt
#	test/unittest/xmlparser/CMakeLists.txt
Refs #3371 Requested changes in GitHub
0b632dc
Refs #3538 Rebase related fixes
cf933f9
Refs #3538 Dynamic types merge
bd0aa43
Refs #3538 Regenerated files from idl as test of the merge.
6fcde4d
Refs #3538 PR requested changes.
a4d3f60
@richiware
Refs #3538 Using quotes instead angled brackets.
50e2f93
Refs #3538 Make DynamicHelloWorld communicate with classic HelloWorld.
78ddfca
Refs #3563. Fix compilation warnings and linking errors on Windows
c347b8a
Refs #3563. Create a mocked QosPolicies to remove the dependency with…
83f0721 
… Dynamictypes of the transport unittests and remove TODO comments
Refs #3563. Fix issues with tabs.
b2f723c
#3538 Rename XML Tag "transports" and "transport" for "transport_desc…
8e0dfde 
…riptors" and "transport_descriptor" to avoid misunderstandings in the XML configuration files.
Refs #3565. Update the parsing of publishers and subscribers to use o…
88466dc 
…nly the same level than participants, and remove the way to parse them inside of a participant
Refs #3538 Create a releaser objects to delete the dynamic factories …
89424c6 
…and fix memory leaks
@richiware
Refs #3538. Fixing compile error on a security test.
4430c58
Refs #3565 Fix compilation error after the rebase
9c6c754
@richiware richiware merged commit c717704 into develop Oct 22, 2018
@richiware richiware deleted the feature/dynamic-types branch October 22, 2018 13:15
@MiguelCompany MiguelCompany mentioned this pull request Nov 7, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richiware richiware richiware approved these changes

Assignees

@richiware richiware

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LuisGP @richiware @JuanCarlos-Arce