-
Notifications
You must be signed in to change notification settings - Fork 770
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[14681] Fixing WriterProxyData clear() method #2810
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Miguel Barro <miguelbarro@eprosima.com>
jsan-rt
approved these changes
Jul 5, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@richiprosima Please test this for me 👀 |
MiguelCompany
approved these changes
Jul 6, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@Mergifyio backport 2.6.x 2.3.x 2.1.x |
mergify bot
pushed a commit
that referenced
this pull request
Jul 6, 2022
Signed-off-by: Miguel Barro <miguelbarro@eprosima.com> (cherry picked from commit 6b5e9c3)
mergify bot
pushed a commit
that referenced
this pull request
Jul 6, 2022
Signed-off-by: Miguel Barro <miguelbarro@eprosima.com> (cherry picked from commit 6b5e9c3)
mergify bot
pushed a commit
that referenced
this pull request
Jul 6, 2022
Signed-off-by: Miguel Barro <miguelbarro@eprosima.com> (cherry picked from commit 6b5e9c3)
✅ Backports have been created
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Miguel Barro miguelbarro@eprosima.com
Description
The use of common proxy pools in the EDP management was generating issues due to the improper clean up of the proxies.
Contributor Checklist
versions.md
file (if applicable).Reviewer Checklist