Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14681] Fixing WriterProxyData clear() method #2810

Merged
merged 1 commit into from
Jul 6, 2022
Merged

[14681] Fixing WriterProxyData clear() method #2810

merged 1 commit into from
Jul 6, 2022

Conversation

MiguelBarro
Copy link
Contributor

Signed-off-by: Miguel Barro miguelbarro@eprosima.com

Description

The use of common proxy pools in the EDP management was generating issues due to the improper clean up of the proxies.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • [ ]NA Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added.
  • Any new/modified methods have been properly documented using Doxygen.
  • Fast DDS test suite has been run locally.
  • Changes are ABI compatible.
  • Changes are API compatible.
  • Documentation builds and tests pass locally.
  • New feature has been added to the versions.md file (if applicable).
  • New feature has been documented/Current behavior is correctly described in the documentation.

Reviewer Checklist

  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

Refs 14681. Fixing WriterProxyData clear() method
e59572e 
Signed-off-by: Miguel Barro <miguelbarro@eprosima.com>
@MiguelBarro MiguelBarro requested a review from jsan-rt July 5, 2022 13:38
@MiguelBarro MiguelBarro self-assigned this Jul 5, 2022
jsan-rt
jsan-rt approved these changes Jul 5, 2022
View reviewed changes
Copy link
Contributor

@jsan-rt jsan-rt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MiguelBarro
Copy link
Contributor Author

@richiprosima Please test this for me 👀

MiguelCompany
MiguelCompany approved these changes Jul 6, 2022
View reviewed changes
Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MiguelCompany MiguelCompany merged commit 6b5e9c3 into master Jul 6, 2022
@MiguelCompany MiguelCompany deleted the bugfix/writer_proxy_data_clear branch July 6, 2022 05:24
@MiguelCompany
Copy link
Member

@Mergifyio backport 2.6.x 2.3.x 2.1.x

mergify bot pushed a commit that referenced this pull request Jul 6, 2022
@MiguelBarro @mergify
Fixing WriterProxyData clear() method (#2810)
b5868a9 
Signed-off-by: Miguel Barro <miguelbarro@eprosima.com>
(cherry picked from commit 6b5e9c3)
@mergify mergify bot mentioned this pull request Jul 6, 2022
Merged
mergify bot pushed a commit that referenced this pull request Jul 6, 2022
@MiguelBarro @mergify
Fixing WriterProxyData clear() method (#2810)
4645ccd 
Signed-off-by: Miguel Barro <miguelbarro@eprosima.com>
(cherry picked from commit 6b5e9c3)
@mergify mergify bot mentioned this pull request Jul 6, 2022
Merged
mergify bot pushed a commit that referenced this pull request Jul 6, 2022
@MiguelBarro @mergify
Fixing WriterProxyData clear() method (#2810)
64beac3 
Signed-off-by: Miguel Barro <miguelbarro@eprosima.com>
(cherry picked from commit 6b5e9c3)
@mergify mergify bot mentioned this pull request Jul 6, 2022
Merged
@mergify
Copy link
Contributor

mergify bot commented Jul 6, 2022

backport 2.6.x 2.3.x 2.1.x

✅ Backports have been created

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MiguelCompany MiguelCompany MiguelCompany approved these changes

@jsan-rt jsan-rt jsan-rt approved these changes

Assignees

@MiguelBarro MiguelBarro

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MiguelBarro @MiguelCompany @jsan-rt