Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRAFT: DynamicDataHelper::print can print Sequences as well as Arrays #2827

Conversation

willstott101
Copy link
Contributor

@willstott101 willstott101 commented Jul 8, 2022

Description

Sequence dynamic data types were indexed in the same way as fixed-length arrays in the DynamicDataHelper.

@Mergifyio backport (branch/2.7.x)
@Mergifyio backport (branch/2.6.x)
Maybe more...

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added.
  • Any new/modified methods have been properly documented using Doxygen.
  • Fast DDS test suite has been run locally.
  • Changes are ABI compatible.
  • Changes are API compatible.
  • Documentation builds and tests pass locally.
  • New feature has been added to the versions.md file (if applicable).
  • New feature has been documented/Current behavior is correctly described in the documentation.

Reviewer Checklist

  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

I'm leaving this as a draft until I've completed the extensive checklist... might be worth noting that I can't find any tests for this Helper at all atm - do I need to create some to get this merged?

@willstott101 willstott101 force-pushed the bugfix/dynamic-sequence-print branch from 927bb61 to 74e82a0 Compare July 8, 2022 14:26
Signed-off-by: Will Stott <willstott101@gmail.com>
@willstott101 willstott101 force-pushed the bugfix/dynamic-sequence-print branch from 74e82a0 to 7c04c8d Compare July 8, 2022 14:39
@methylDragon
Copy link
Contributor

methylDragon commented Sep 19, 2022

Is this still a draft? In the absence of tests for DynamicDataHelper, this would be very nice to get in for convenient printing of dynamic data

I've tested the fix locally, and it fixes the issues as expected.

@MiguelCompany
Copy link
Member

Closing in favor of #2957, where the changes here have been included

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants