Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build on old compilers when FASTDDS_STATISTICS is define #2928

Closed
wants to merge 6 commits into from
Closed

Fix build on old compilers when FASTDDS_STATISTICS is define #2928

wants to merge 6 commits into from

Conversation

tongtongdi
Copy link
Contributor

@tongtongdi tongtongdi commented Aug 25, 2022 •
edited
Loading

when define FASTDDS_STATISTICS, user gcc5.4 can't compilers.
I fix it same as #2220

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added.
  • Any new/modified methods have been properly documented using Doxygen.
  • Fast DDS test suite has been run locally.
  • Changes are ABI compatible.
  • Changes are API compatible.
  • Documentation builds and tests pass locally.
  • New feature has been added to the versions.md file (if applicable).
  • New feature has been documented/Current behavior is correctly described in the documentation.

Reviewer Checklist

  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

JLBuenoLopez
JLBuenoLopez reviewed Aug 26, 2022
View reviewed changes
Copy link
Contributor

@JLBuenoLopez JLBuenoLopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for your contribution @tongtongdi!

Could you please fix the DCO (more information clicking on the failed verification) and apply the project's code style (enforced with uncrustify. You can find the configuration here)?

Thanks!

wangtong and others added 5 commits August 26, 2022 14:33
Fix build on old compilers when FASTDDS_STATISTICS is define
118884f
Fix build on old compilers when FASTDDS_STATISTICS is define
cb33974
@rsanchez15
Get WAN address API in TCPv4 transport descriptors (#2877)
9498b8d 
* Set WAN address API

Signed-off-by: RaulSanchez <raul@eprosima.com>

* Add test

Signed-off-by: RaulSanchez <raul@eprosima.com>

* Add API extension to versions.md

Signed-off-by: RaulSanchez <raul@eprosima.com>

Signed-off-by: RaulSanchez <raul@eprosima.com>
Signed-off-by: wangtong <wangtong11@xiaomi.com>
Fix build on old compilers when FASTDDS_STATISTICS is define
f16d57e 
Signed-off-by: wangtong <wangtong11@xiaomi.com>
Merge github.com:tongtongdi/Fast-DDS
1cc33a5 
Signed-off-by: tongtongdi <729728698@qq.com>
@tongtongdi tongtongdi closed this Aug 26, 2022
@tongtongdi
Copy link
Contributor Author

LGTM! Thanks for your contribution @tongtongdi!

Could you please fix the DCO (more information clicking on the failed verification) and apply the project's code style (enforced with uncrustify. You can find the configuration here)?

Thanks!

i close this, open a new one. #2929

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JLBuenoLopez JLBuenoLopez JLBuenoLopez left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tongtongdi @JLBuenoLopez @rsanchez15